enhancement: Verbose Test Harness #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
added
tech debt
tzaffi
commented
May 23, 2023
1 task
tzaffi
commented
May 23, 2023
tzaffi
commented
May 23, 2023
tzaffi
commented
May 23, 2023
tzaffi
commented
May 23, 2023
tzaffi
commented
May 23, 2023
tzaffi
commented
May 23, 2023
This was referenced May 23, 2023
Contributor
Eric-Warehime
left a comment
Eric-Warehime
left a comment
There was a problem hiding this comment.
LGTM, you just need to update the sdk testing branch to master
winder
approved these changes
May 24, 2023
Contributor
winder
left a comment
winder
left a comment
There was a problem hiding this comment.
LGTM, just need to update the branch.
algochoi
approved these changes
May 24, 2023
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
LGTM, thanks! very helpful for debugging
This was referenced Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To improve visibility of C.I. build failures, utilize new logging capabilities in the sandbox (algorand/sandbox#181) and set
VERBOSE_HARNESS=1.In particular we can now see:
docker compose upcommanddocker-compose logsfor:TODO
What does a successful build look like?
See for example this build. You'll need to download Circle's log as the max display at Circle is 400K characters.
What does a failed build look like?
As a test case I pinned the companion algorand-sdk-testing PR (algorand/algorand-sdk-testing#288) to a broken indexer commit. The build broke early enough to see the entire logs directly on circle. There are two highlights to look for:
docker compose logsare dumped for each of the services and at the end we see could not load genesis...