-
Notifications
You must be signed in to change notification settings - Fork 103
bugfix: adding EvalDelta.SharedAccts #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
algochoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - it looks like the codec:allocbound is defined for all the fields here in go-algorand but not here (like logs, innerTxns). Is this inconsequential?
Good catch. I've modified the fields in @Eric-Warehime - do you know if this is used programmatically in some way (you'd need reflection)? Or are these purely informational? |
I think it's just used by the msgp gen code i.e. https://github.com/algorand/msgp/blob/26c81f33bddb2b3897a722290e67e9e363ca96d1/parse/getast.go#L423 So I don't think it's needed here--probably was just copied as is. But it's good to keep consistent. |
Add missing field in
EvalDeltaThe Shared Resources work algorand/go-algorand#5035 introduced a new field in
data.transactions.EvalDelta. This PR adds it to the mirror typetypes.EvalDelta.Testing
As of 15May2023 there is a draft PR in go-algorand algorand/go-algorand#5381 with a test that validates the types against this PR.