chore: release v4.8.0 #1228
Merged
chore: release v4.8.0 #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a3ca36f:
|
eunjae-lee
approved these changes
Nov 19, 2020
Contributor
eunjae-lee
left a comment
eunjae-lee
left a comment
There was a problem hiding this comment.
Looks good to me, but I'm re-running the test to see if the failed test passes now.
Contributor
Author
those two are always flaky and eventually pass. I really need to look into making them less brittle |
Contributor
Author
|
merging, since the release will only happen once the tests pass on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request prepares the following release:
4.7.0→4.8.0Release Summary
This is going to be published with the following command:
Merging Instructions
When merging this pull request, you need to Squash and merge and make sure that the title starts with
chore: release v4.8.0.See details
After that, a commit
chore: release v4.8.0will be added and you or your CI can runshipjs triggerto trigger the release based on the commit.This pull request is automatically generated by Ship.js.