-
-
Notifications
You must be signed in to change notification settings - Fork 298
istio = "1.26.0" kagent = "0.3.2" #1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 💡 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
58c19e8
to
1f4e0fc
Compare
kagent = "0.3.2" readme Signed-off-by: Dmytro Rashko <[email protected]> Author: Dmytro Rashko <[email protected]> Date: Fri May 9 13:22:39 2025 +0200 Changes to be committed: modified: README.md modified: cmd/apps/istio_app.go new file: cmd/apps/kagent_app.go modified: cmd/install.go modified: pkg/get/tools.go
@alexellis is there anything else missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the differences between Apps and Tools in an Arkade context and ensure the changes appropriately align with those. I don't know enough about kagent currently to know whether putting into both is what you need to do.
@@ -833,6 +833,7 @@ There are 52 apps that you can install on your cluster. | |||
| [k3sup](https://github.com/alexellis/k3sup) | Bootstrap Kubernetes with k3s over SSH < 1 min. | | |||
| [k9s](https://github.com/derailed/k9s) | Provides a terminal UI to interact with your Kubernetes clusters. | | |||
| [kail](https://github.com/boz/kail) | Kubernetes log viewer. | | |||
| [kagent](https://github.com/boz/kail) | Cloud Native Agentic AI | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy and paste error here, which is odd because this table can be generated as per the footnote.
As two apps have been added there should also be some updates to the apps section
@@ -23,7 +23,7 @@ import ( | |||
const ( | |||
// A default Istio version, get the latest from: | |||
// https://github.com/istio/istio/releases/latest | |||
istioVer = "1.25.0" | |||
istioVer = "1.26.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have some testing to demonstrate that the minor release hasn't upset the existing install code, please.
@@ -4627,5 +4627,27 @@ https://github.com/grafana/alloy/releases/download/{{.Version}}/{{$fileName}}`, | |||
{{.Name}}-{{.Version}}-{{$os}}-{{$arch}}.{{$ext}} | |||
`, | |||
}) | |||
|
|||
tools = append(tools, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the idea here? Is Kagent a cli as well as an app?
Description
istio = "1.26.0"
kagent = "0.3.2"
Motivation and Context
New app kagent - https://kagent.dev
https://github.com/kagent-dev/kagent/releases
How Has This Been Tested?
go build && ./hack/test-tool.sh kagent
Types of changes
Documentation
./arkade get --format markdown
./arkade install --help
Checklist:
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I've read the CONTRIBUTION guide
I have signed-off my commits with
git commit -s
I have tested this on arm, or have added code to prevent deployment