Skip to content

Conversation

dimetron
Copy link

@dimetron dimetron commented May 8, 2025

Description

istio = "1.26.0"
kagent = "0.3.2"

Motivation and Context

New app kagent - https://kagent.dev

https://github.com/kagent-dev/kagent/releases

How Has This Been Tested?

go build && ./hack/test-tool.sh kagent

Types of changes

  • New feature (non-breaking change which adds functionality)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.

  • My change requires a change to the documentation.

  • I have updated the documentation accordingly.

  • I've read the CONTRIBUTION guide

  • I have signed-off my commits with git commit -s

  • I have tested this on arm, or have added code to prevent deployment

@derek derek bot added the new-contributor label May 8, 2025
Copy link

derek bot commented May 8, 2025

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "[email protected]"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

@derek derek bot added the no-dco label May 8, 2025
@dimetron dimetron changed the title istio = "1.26.0" istio = "1.26.0" kagent = "0.3.2" May 8, 2025
@derek derek bot removed the no-dco label May 9, 2025
@dimetron dimetron force-pushed the master branch 2 times, most recently from 58c19e8 to 1f4e0fc Compare May 9, 2025 15:59
kagent = "0.3.2"
readme

Signed-off-by: Dmytro Rashko <[email protected]>

Author:    Dmytro Rashko <[email protected]>
Date:      Fri May 9 13:22:39 2025 +0200

Changes to be committed:
	modified:   README.md
	modified:   cmd/apps/istio_app.go
	new file:   cmd/apps/kagent_app.go
	modified:   cmd/install.go
	modified:   pkg/get/tools.go
@dimetron
Copy link
Author

@alexellis is there anything else missing?
//trying to learn a new contributor.

@alexellis
Copy link
Owner

Hi @dimetron

We need some evidence of testing - console output / ascii cinema

@rgee0 could you review the new app?

Thanks,

Alex

Copy link
Contributor

@rgee0 rgee0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the differences between Apps and Tools in an Arkade context and ensure the changes appropriately align with those. I don't know enough about kagent currently to know whether putting into both is what you need to do.

@@ -833,6 +833,7 @@ There are 52 apps that you can install on your cluster.
| [k3sup](https://github.com/alexellis/k3sup) | Bootstrap Kubernetes with k3s over SSH < 1 min. |
| [k9s](https://github.com/derailed/k9s) | Provides a terminal UI to interact with your Kubernetes clusters. |
| [kail](https://github.com/boz/kail) | Kubernetes log viewer. |
| [kagent](https://github.com/boz/kail) | Cloud Native Agentic AI |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy and paste error here, which is odd because this table can be generated as per the footnote.

As two apps have been added there should also be some updates to the apps section

@@ -23,7 +23,7 @@ import (
const (
// A default Istio version, get the latest from:
// https://github.com/istio/istio/releases/latest
istioVer = "1.25.0"
istioVer = "1.26.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have some testing to demonstrate that the minor release hasn't upset the existing install code, please.

@@ -4627,5 +4627,27 @@ https://github.com/grafana/alloy/releases/download/{{.Version}}/{{$fileName}}`,
{{.Name}}-{{.Version}}-{{$os}}-{{$arch}}.{{$ext}}
`,
})

tools = append(tools,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the idea here? Is Kagent a cli as well as an app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants