Custom names for sessions tables

[alexedwards]

As per the comments on #177, consider supporting custom names for the sessions tables where it makes sense.

[doggedOwl]

Table name is an implementation detail of the relational db stores so I think it's fine to implement it store by store like in the PR at #177.

For consistency it may be usefull to add it to all of stores backed by a relational db, more or less the equivalent of the prefix option for the KV stores.

Setting the tablename after init though (using SetSessionsTableName like in #177) does not seem right so maybe it would be better to have a new constructor:
func NewWithOptions(pool *pgxpool.Pool, cleanupInterval time.Duration, tableName string) *PostgresStore

This again mirrors more or less the
func NewWithOptions(client *api.Client, cleanupInterval time.Duration, prefix string) *ConsulStore for example.

[alexedwards]

I like the idea of a NewWithOptions() approach. The consulstore implementation already has a NewWithOptions() function with a different signature, so perhaps we could call it NewWithConfig() instead. Perhaps we could make Config a struct and pass it as a 2nd parameter to allow further options in the future without making breaking changes to the public API. So, for postgresstore for example:

type Config struct {
    CleanupInterval time.Duration
    TableName string
}

Which could then be used like:

postgresstore.NewWithConfig(db, postgresstore.Config{
    CleanupInterval: time.Minute,
    TableName: "mycustomsessions",
})

If any fields in Config are not provided (i.e. they contain the relevant zero value), then we can use a sensible default (i.e. cleanup interval of 5 minutes, table name of "sessions").

I think we could potentially roll this pattern out across all the different stores and deprecate the NewWithPrefix() and NewWithCleanupInterval() functions on the individual stores, leaving each store with two ways to initialize it: either New() (which uses the defaults) or NewWithConfig() which allows you to customize the behavior in whatever way makes sense for that particular store.

[Kraysent]

That would be a nice feature!

Maybe instead of whole separate constructor one might consider using Functional Options pattern. See pull request #190 for the prototype.

In this case, no backwards compatibility is broken: New(db) will fall back to the same names as now.
If one wants to change the default name (and schema for that matter) of the table as well as column names, they can use nice syntax:

New(db,
  WithSessionTableName("schema.session_table"),
  WithExpiryColumnName("expiry_date"),
  WithTokenColumnName("token"),
  // data column will not change!
)

As a bonus, one may change cleanupInterval the same way (also without breaking backwards compatibility):

New(db, WithCleanupInterval(10*time.Minute))

It seems to me that such implementation would solve all the problems above and is applicable to any other store. Feel free to point at anything I might have forgotten!

[vanyauhalin]

Greetings. Is there any progress on this issue?

[alexedwards]

No progress as yet. I've added the 'help wanted' label to this issue, as I'm quite pushed for time and it isn't a priority for me.

If anyone is reading this and would like to help, a PR that implements the changes described in #180 (comment) for all stores, that would be really useful and appreciated! If you have any clarification questions, please let me know.