setup.py: Import distutils directly instead of through setuptools #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mweinelt you can also do |
mweinelt
force-pushed
the
setuptools-65.6.0-compat
branch
2 times, most recently
from
9c460ca to
9bd950b
Compare
In setuptools 65.6.0 the vendored distutils package changed to relative imports. Importing `Command` from `setuptools._distutils` previously worked but now fails because it imports an unpatched version of distutils, which breaks the build. Importing `Command` directly from `distutils` or `setuputils` will receive a monkey patched version that works. Reported upstream at pypa/setuptools#3743 and the problem was investigated by Anderson Bravalheri. Closes: alan-turing-institute#77
mweinelt
force-pushed
the
setuptools-65.6.0-compat
branch
from
9bd950b to
1083f38
Compare
Collaborator
|
Thanks for opening this PR @mweinelt, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In setuptools 65.6.0 the vendored distutils package changed to relative
imports. Importing
Commandfromsetuptools._distutilspreviouslyworked but now fails because it imports an unpatched version of
distutils, which breaks the build.
Importing
Commanddirectly fromdistutilsorsetuputilswillreceive a monkey patched version that works.
Reported upstream at pypa/setuptools#3743 and the problem was investigated by Anderson Bravalheri.
Closes: #77