Update ember-ajax to version 3.0.0 🚀 #78
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
ember-ajax just published its new version 3.0.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of ember-ajax.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
Breaking Changes
Simplifying
normalizeErrorResponseAfter much discussion, the team around
ember-ajaxdecided that it was probably not a great idea to reformat the error payload to match some arbitrary format that we designed. Instead, we should just use the payload that the server returned.If you want to maintain the old behavior, you can include the the
legacy/normalize-error-responsemixin, which has the old version of the method included and will override the new behavior.Replacing
AjaxError.errorswithAjaxError.payloadThe
errorsproperty on anyAjaxErrorsubclass has been deprecated in favor of apayloadproperty for a while now. If you want access to the response from the server, you should now use thepayloadproperty, like so:No longer modify null or undefined server response (#232)
If your server response is interpreted by jQuery#ajax to be
nullorundefined, we will resolve that value, instead of turning it into an empty object.The new version differs by 126 commits .
2aba19eReleased v3.0.05c6a45aUpgrade dependencies (#283)acd384ffix(package): update ember-cli-babel to version 6.0.0-beta.10 (#277)c70bc9aUpdate to use Babel 6 (#266)528e843Upgradeember-resolverto 4.1.04181656Released v3.0.0-beta.186ab8d0Fix issues with the isString helper723dd66Tighten ESLint config78de692Hide container by default when running testsac023c1Slight cleanup of JSON test helper60cb8demake sure contentType is a string before running a regex match (#250)4e784a2Released v3.0.0-beta.0fe03044Released v2.5.7-beta.0db086b3Released v2.5.71f4ca9dSimplifynormalizeErrorResponse(#265)There are 126 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.