Qos2 idempotent producer #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Jan 25, 2024
There was a problem hiding this comment.
The cyclomatic complexity of the code has gone up quite a bit with these proposed changes.
MqttKafkaSessionFactory
MqttSessionProxy
-> KafkaOffsetFetchStream
-> KafkaInitProducerStream
-> KafkaOffsetCommitStream
-> MqttKafkaPublishFactory.MqttPublishProxy
-> MqttKafkaPublishFactory.KafkaProxy
-> MqttKafkaPublishFactory.KafkaMessagesProxy
-> MqttKafkaPublishFactory.KafkaRetainedProxy
MqttKafkaPublishFactory
MqttPublishProxy
-> MqttKafkaSessionFactory.MqttSessionProxy
In general, we don't want to reach across stream factories for behavior, even doing so for state should be kept to a minimum.
In this case, we had discussed a minor change to have session handle offset commit instead of publish, but this change seems to have more inter-stream behavioral dependencies than that.
Perhaps we should have a discussion about it to determine how best to simplify if possible.
.../main/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/MqttKafkaConfiguration.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaPublishFactory.java
Show resolved
Hide resolved
jfallows
requested changes
Feb 1, 2024
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
Comment on lines
+2016
to
+2017
| return new String16FW(BitUtil.toHex(offsetMetadata.buffer().byteArray(), | ||
| offsetMetadata.offset(), offsetMetadata.limit())); |
There was a problem hiding this comment.
We'll want to optimize this at some point to avoid allocation during qos2 ack.
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaPublishFactory.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Feb 5, 2024
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/PublishClientMetadata.java
Outdated
Show resolved
Hide resolved
...java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/PublishClientMetadata.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
specs/binding-mqtt.spec/src/main/resources/META-INF/zilla/mqtt.idl
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Show resolved
Hide resolved
...t.spec/src/test/java/io/aklivity/zilla/specs/binding/mqtt/streams/application/PublishIT.java
Outdated
Show resolved
Hide resolved
...t.spec/src/test/java/io/aklivity/zilla/specs/binding/mqtt/streams/application/PublishIT.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Feb 5, 2024
...qtt-kafka.spec/src/test/java/io/aklivity/zilla/specs/binding/mqtt/kafka/streams/KafkaIT.java
Outdated
Show resolved
Hide resolved
...mqtt-kafka.spec/src/test/java/io/aklivity/zilla/specs/binding/mqtt/kafka/streams/MqttIT.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaPublishProxyIT.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSessionFactory.java
Show resolved
Hide resolved
jfallows
previously approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.