support secure otlp exporter
#1579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Sep 29, 2025
...otlp/src/main/java/io/aklivity/zilla/runtime/exporter/otlp/internal/OltpExporterHandler.java
Outdated
Show resolved
Hide resolved
...n/java/io/aklivity/zilla/runtime/exporter/otlp/internal/config/OtlpOptionsConfigAdapter.java
Outdated
Show resolved
Hide resolved
...est/java/io/aklivity/zilla/runtime/exporter/otlp/internal/config/OtlpExporterConfigTest.java
Show resolved
Hide resolved
...me/exporter-otlp/src/test/java/io/aklivity/zilla/runtime/exporter/otlp/internal/EventIT.java
Outdated
Show resolved
Hide resolved
...me/exporter-otlp/src/test/java/io/aklivity/zilla/runtime/exporter/otlp/internal/EventIT.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Sep 30, 2025
Comment on lines
73
to
81
| URI endpoint; | ||
| if (matcher.reset(overrides.metrics.toString()).matches()) | ||
| { | ||
| endpoint = overrides.metrics; | ||
| } | ||
| else | ||
| { | ||
| endpoint = location.resolve(overrides.metrics); | ||
| } |
There was a problem hiding this comment.
Can we simplify this by using location.resolve(overrides.metrics) in both cases (relative path or absolute URI)?
| this.overrides = endpoint.overrides; | ||
| } | ||
|
|
||
| public URI resolveMetrics() |
There was a problem hiding this comment.
This is only used internally so no need to public, right?
Comment on lines
86
to
99
| public URI resolveLogs() | ||
| { | ||
| URI endpoint; | ||
| if (matcher.reset(overrides.logs.toString()).matches()) | ||
| { | ||
| endpoint = overrides.logs; | ||
| } | ||
| else | ||
| { | ||
| endpoint = location.resolve(overrides.logs); | ||
| } | ||
|
|
||
| return endpoint; | ||
| } |
There was a problem hiding this comment.
Equivalent feedback as metrics above.
| OtlpOverridesConfig overrides = endpoint.overrides; | ||
| this.metricsEndpoint = location.resolve(overrides.metrics); | ||
| this.logsEndpoint = location.resolve(overrides.logs); | ||
| this.metricsEndpoint = exporter.resolveMetrics(); |
There was a problem hiding this comment.
We don't need metricsEndpoint or logsEndpoint as a field since the endpoint is already in the corresponding client, right?
| { | ||
| return new OltpExporterHandler(config, context, exporter, collector, resolveKind, attributes); | ||
| OtlpExporterConfig otlpExporter = new OtlpExporterConfig(config, context, exporter); | ||
| return new OltpExporterHandler(config, context, otlpExporter, (OtlpOptionsConfig) exporter.options, |
There was a problem hiding this comment.
No need to pass options separately from otlpExporter as otlpExporter.options is already correct type and reachable from handler.
jfallows
previously approved these changes
Sep 30, 2025
jfallows
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1556