Handle reserved budget in HTTP end frame #1430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
changed the title
jfallows
requested changes
Mar 12, 2025
...java/io/aklivity/zilla/runtime/binding/grpc/kafka/internal/stream/GrpcKafkaProxyFactory.java
Outdated
Show resolved
Hide resolved
Comment on lines
409
to
415
| private int replyPadding; | ||
| private long replyBudgetId; | ||
| private int replyMax; | ||
| private int replyPadding; |
There was a problem hiding this comment.
Suggested change
| private int replyPadding; | |
| private long replyBudgetId; | |
| private int replyMax; | |
| private int replyPadding; | |
| private long replyBud; | |
| private int replyPad; | |
| private int replyMax; |
| String16FW status) | ||
| { | ||
| server.doGrpcNetStatus(traceId, authorization, status); | ||
| server.doGrpcNetStatus(traceId, authorization, server.replyPadding, status); |
There was a problem hiding this comment.
Is this correct? (padding for reserved as parameter)
There was a problem hiding this comment.
No, it is not correct it should be 0 as we are handeling abort which was not claimed anywhere. Thanks for the catch.
jfallows
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.