Support configurable TLS client SNI validation and handle FQDNs … #1383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…with trailing dot
When a Kafka server hostname has a trailing dot, such as
server.dev.local.then we implicitly pick this up as both the remote DNS name (for TCP) and the remote SNI Hostname (for TLS).However, SNI Hostname does not support a trailing dot, and parts of the Java SSLEngine API remove it implicitly. Therefore, we need to also remove this implicitly when necessary in TLS client.
Note that DNS resolution considers
server.dev.local.(absolute) andserver.dev.local(relatve to . = root) as equivalent.For example:
and
both work correctly as expected.
This is because the server certificate has a
CommonNameofwww.google.comin both cases.If the server certifciate presents a
CommonNamewith trailing dot, then TLS Hostname Verification must also be disabled by passing-Pzilla.binding.tls.client.https.identification=falsetozilla start.