Skip to content

Conversation

@jfallows
Copy link
Contributor

@jfallows jfallows commented Aug 1, 2024

Description

Refactor asyncapi binding

  • remove custom 3.0.2-zilla asyncapi version schema
  • model includes zilla specific bindings extensions via x- prefix
  • view spans entire model at creation
  • view handles resolution of model refs
  • view handles resolution of server variables
  • simplify composite generators for client, server and proxy
  • use fluent builder apis to maintain code structure reflecting config syntax
  • introduce composite id in frame extension and with config
  • generated config includes per route with config composite id referencing apiId and operation
  • http, sse, mqtt, http-kafka, sse-kafka, mqtt-kafka include with composite id in routed begin frame
  • use composite id to efficiently determine apiId and operation when composite begin frame arrives at asyncapi binding

Fixes #1151

@jfallows jfallows requested review from akrambek and bmaidics August 1, 2024 06:01
io/aklivity/zilla/specs/binding/asyncapi/schema/asyncapi.schema.patch.json,
io/aklivity/zilla/specs/binding/asyncapi/schema/asyncapi.2.6.0.schema.json,
io/aklivity/zilla/specs/binding/asyncapi/schema/asyncapi.3.0.1.schema.json,
io/aklivity/zilla/specs/binding/asyncapi/schema/asyncapi.3.0.2-zilla.schema.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this include as we don't use our own Asyncapi scheme (also it was removed).

@jfallows jfallows merged commit 36016d7 into aklivity:develop Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify sse support in AsyncAPI specs

3 participants