feat: replace port 8080 with 12345 #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
reviewed
May 31, 2024
There was a problem hiding this comment.
@vordimous Let's use a port outside the ephemeral port range 49152-65535, such as 12345, instead of 54321.
https://en.wikipedia.org/wiki/Ephemeral_port
vordimous
force-pushed
the
use-dummy-port-for-tests
branch
from
d677087 to
743f615
Compare
vordimous
changed the title
vordimous
force-pushed
the
use-dummy-port-for-tests
branch
2 times, most recently
from
3fc67be to
cc6b550
Compare
also update any 808x ports
vordimous
force-pushed
the
use-dummy-port-for-tests
branch
from
cc6b550 to
f79e966
Compare
jfallows
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also update any 808x ports
Description
This change uses a dummy
12345port for tests such that it is unlikely to conflict with any other services running locally.