Added declarative helmfile #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vordimous
reviewed
May 28, 2024
| - name: zilla | ||
| namespace: zilla | ||
| chart: oci://ghcr.io/aklivity/charts/zilla | ||
| version: 0.9.81 |
There was a problem hiding this comment.
I think we will need a way to dynamically set this field right @attilakreiner?
There was a problem hiding this comment.
My suggestion is that we go with ^0.9.0 so it is consistent with our examples e.g. setup.sh#L6
attilakreiner
suggested changes
May 29, 2024
| - name: zilla | ||
| namespace: zilla | ||
| chart: oci://ghcr.io/aklivity/charts/zilla | ||
| version: 0.9.81 |
There was a problem hiding this comment.
My suggestion is that we go with ^0.9.0 so it is consistent with our examples e.g. setup.sh#L6
|
@vordimous @attilakreiner The file is updated with the recommended version range |
attilakreiner
approved these changes
May 30, 2024
vordimous
approved these changes
May 30, 2024
jfallows
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A simple declarative way to deploy Zilla to Kubernetes with Helm as described in Zilla HelmChart docs.
helmfile
https://helmfile.readthedocs.io/