Unsubscribe on partition reassignment #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
May 15, 2024
| private final ArrayList<KafkaCacheServerConsumerStream> streams; | ||
| private final Object2ObjectHashMap<String, String> members; | ||
| private final Map<String, String> members; | ||
| private final ObjectHashSet<String> tempMembers; |
There was a problem hiding this comment.
Suggested change
| private final ObjectHashSet<String> tempMembers; | |
| private final ObjectHashSet<String> memberIds; |
| this.streams = new ArrayList<>(); | ||
| this.members = new Object2ObjectHashMap<>(); | ||
| this.tempMembers = new ObjectHashSet<>(); | ||
| this.members = new LinkedHashMap<>(); |
There was a problem hiding this comment.
Are we switching to LinkedHashMap to maintain insertion order, or for putIfAbsent?
Note: putIfAbsent is also available on Object2ObjectHashMap, inherited from Map.
There was a problem hiding this comment.
to maintain insertion order
Comment on lines
943
to
946
| KafkaDataExFW extension) | ||
| Flyweight extension) |
There was a problem hiding this comment.
Is this change necessary?
jfallows
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unsubscribe on partition reassignment
Fixes #882