[Query] Add non-generic ReadJournalFor API
#7679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Jun 4, 2025
| { | ||
| public sealed class PersistenceQuery : IExtension | ||
| { | ||
| private static readonly Type ReadJournalType = typeof(IReadJournal); |
There was a problem hiding this comment.
Type cache of IReadJournal
| _system = system; | ||
| } | ||
|
|
||
| public TJournal ReadJournalFor<TJournal>(string readJournalPluginId) where TJournal : IReadJournal |
There was a problem hiding this comment.
Old API is left intact
Comment on lines
+43
to
+44
| if(!ReadJournalType.IsAssignableFrom(readJournalType)) | ||
| throw new ArgumentException("Must implement IReadJournal interface", nameof(readJournalType)); |
There was a problem hiding this comment.
Added type checking code to make sure that readJournalType implements IReadJournal
This was referenced Jul 25, 2025
This was referenced Aug 4, 2025
This was referenced Aug 15, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7678
Changes
Add non-generic
ReadJournalForAPIChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):