Modernize DistributedPubSub code #7640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new ArgumentException($"The cluster member [{_cluster.SelfAddress}] doesn't have the role [{_settings.Role}]"); | ||
|
|
||
| //Start periodic gossip to random nodes in cluster | ||
| _gossipCancelable = Context.System.Scheduler.ScheduleTellRepeatedlyCancelable(_settings.GossipInterval, _settings.GossipInterval, Self, GossipTick.Instance, Self); |
There was a problem hiding this comment.
LGTM (should probably keep the comment though)
There was a problem hiding this comment.
the comment was moved to the PreStart() override where we start the periodic timer
| { | ||
| var nodes = state.Members | ||
| .Where(m => m.Status != MemberStatus.Joining && IsMatchingRole(m)) | ||
| .Where(m => m.Status != MemberStatus.Joining && IsMatchingRole(m, _role)) |
There was a problem hiding this comment.
No, it wasn't a bug. We access the _settings.Role property inside the IsMatchingRole method before, now it is a static method
| private void HandleGossip() | ||
| { | ||
| var node = SelectRandomNode(_nodes.Except(new[] { _cluster.SelfAddress }).ToArray()); | ||
| var node = SelectRandomNode(_nodes.Except([_cluster.SelfAddress]).ToArray()); |
There was a problem hiding this comment.
You might be able to make this work without allocating a list - have SelectRandomNode take an IEnumerable and just apply the random value to .Skip instead of the indexer
There was a problem hiding this comment.
That'll also save you the trouble of fully evaluating the list
There was a problem hiding this comment.
I'll give that a try
Aaronontheweb
approved these changes
May 14, 2025
This was referenced Jul 25, 2025
This was referenced Aug 4, 2025
This was referenced Aug 15, 2025
This was referenced Aug 25, 2025
This was referenced Sep 4, 2025
This was referenced Oct 7, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Modernize DistributedPubSub code
DistributedPubSubMediatoruseIWithTimersinstead of using the schedulerTopicLike(base class forTopicandGroup) useIWithTimersinstead of using the schedulerChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksOSVersion: Microsoft Windows NT 6.2.9200.0
ProcessorCount: 24
ClockSpeed: 0 MHZ
Actor Count: 48
Messages sent/received per client: 200000 (2e5)
Is Server GC: True
Thread count: 52
This PR's Benchmarks
OSVersion: Microsoft Windows NT 6.2.9200.0
ProcessorCount: 24
ClockSpeed: 0 MHZ
Actor Count: 48
Messages sent/received per client: 200000 (2e5)
Is Server GC: True
Thread count: 55