Skip to content

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Jan 9, 2025

Changes

  • Change Shard ctor to accept buffer message adapter
  • Add reproduction test

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

@Aaronontheweb
Copy link
Member

Related: petabridge/phobos-issues#84

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to re-arrange the reproduction - don't do anything custom inside the HashCodeMessageExtractor. Handle this in the Unapply method instead.

{
return message switch
{
Message m => m.Payload,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of testing the wrong thing here - the Unapply method should be handling this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no its not, we're testing MyEnvelope, that Message class is the actual message being sent, not a string.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, you're right, there's something wrong with the repro code

@Aaronontheweb Aaronontheweb enabled auto-merge (rebase) January 13, 2025 14:54
This was referenced Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants