Skip to content

Conversation

Horusiath
Copy link
Contributor

  • Akka.Persistence.FSharp and PersistenceExample.FsApi has been moved to src/core and src/examples directories (they were directly in src/ before).
  • Changes considering F# persistence plugin API:
    • exec method doesn't affect the aggregate state now - it can be modified from that method by emitting events with callback in Persist, AsyncPersist and Defer methods of the eventsourced parameter.
    • Methods mentioned above has switched params (callback is defined first, sequence of events second) - I think it better reflects a F#-way of dealing with sequential data
  • F# persistence plugin now exposes a function to spawning guaranteed delivery actors.
  • PersistentViewSpec.PersistentView_should_run_size_limited_updates_on_user_request test has been fixed.

@rogeralsing
Copy link
Contributor

@Horusiath can you fix this PR?
Looks good but can't be merged atm

@Horusiath Horusiath force-pushed the akka-persistence-fsharp branch from 9fad2a3 to 85545c3 Compare February 9, 2015 22:35
@Horusiath
Copy link
Contributor Author

I've fixed some of the compilation problems with F# projects and applied some of the @dsyme suggestions from #538 review:

  • Changed Akka.FSharp from module to namespace, rest of the exposed API has been splitted into separate AutoOpen modules.
  • Strategy factory functions have been refactored to static methods with optional arguments.
  • pub, sub and unsub changed to publish, subscribe and unsubscribe

All of the changes has been updated in docs and examples.

rogeralsing added a commit that referenced this pull request Feb 10, 2015
Akka.Persistence - F# guaranteed delivery, more tests, moved projects
@rogeralsing rogeralsing merged commit fb4f3a3 into akkadotnet:dev Feb 10, 2015
@Horusiath Horusiath deleted the akka-persistence-fsharp branch March 23, 2016 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants