Skip to content

Port Akka.Tests.Actor tests to async/await - ContextWatchWithSpec, ConfigurationSpec #5827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Port Akka.Tests.Actor tests to async/await - ContextWatchWithSpec, ConfigurationSpec #5827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8252485
Port Akka.Tests.Actor tests to async/await - ContextWatchWithSpec, Co…
Arkatufus Apr 7, 2022
fe36322
Merge branch 'feature/async_testkit' into async_testkit/Akka.Tests.Ac…
Aaronontheweb Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/Akka.Tests/Actor/ContextWatchWithSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ public ContextWatchWithSpec(ITestOutputHelper outputHelper)
}

[Fact(Skip = "This test is used with Performance Profiler to check memory leaks")]
public void Context_WatchWith_Should_not_have_memory_leak()
public async Task Context_WatchWith_Should_not_have_memory_leak()
{
using (var actorSystem = ActorSystem.Create("repro"))
{
actorSystem.ActorOf(Props.Create<LoadHandler>());

Thread.Sleep(60.Seconds());
await Task.Delay(60.Seconds());
}
}

Expand Down
5 changes: 3 additions & 2 deletions src/core/Akka.Tests/Configuration/ConfigurationSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
using Akka.Configuration.Hocon;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Akka.Actor;
using Akka.Configuration;
using Akka.Dispatch;
Expand Down Expand Up @@ -86,12 +87,12 @@ public void Deserializes_hocon_configuration_from_net_config_file()

// unit test for bug #4330
[Fact]
public void Should_load_config_from_app_config_file()
public async Task Should_load_config_from_app_config_file()
{
#if !CORECLR
var system = ActorSystem.Create(Guid.NewGuid().ToString());
system.Settings.Config.GetBoolean("nonsense.entry").ShouldBeTrue();
system.Terminate();
await system.Terminate();
#else
// Skip this test for Linux targets
Output.WriteLine("This test is skipped.");
Expand Down