Skip to content

Port Akka.Tests.Actor tests to async/await - FunctionRefSpecs #5777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 29, 2022
Merged

Port Akka.Tests.Actor tests to async/await - FunctionRefSpecs #5777

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8989570
Port `Akka.Tests.Actor` tests to `async/await` - `FunctionRefSpecs`
eaba Mar 29, 2022
f08e87d
Merge branch 'feature/async_testkit' into function_ref_specs
eaba Mar 29, 2022
caf7c7a
Make use of `Task` instead of `ValueTask`
eaba Mar 29, 2022
b0c1442
Merge branch 'feature/async_testkit' into function_ref_specs
Arkatufus Mar 29, 2022
4556e5f
Merge branch 'feature/async_testkit' into function_ref_specs
Arkatufus Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 33 additions & 32 deletions src/core/Akka.Tests/Actor/FunctionRefSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//-----------------------------------------------------------------------

using System;
using System.Threading.Tasks;
using Akka.Actor;
using Akka.Configuration;
using Akka.TestKit;
Expand Down Expand Up @@ -127,56 +128,56 @@ public FunctionRefSpec(ITestOutputHelper output) : base(output, null)
#region top level

[Fact]
public void FunctionRef_created_by_top_level_actor_must_forward_messages()
public async Task FunctionRef_created_by_top_level_actor_must_forward_messages()
{
var s = SuperActor();
var forwarder = GetFunctionRef(s);
var forwarder = await GetFunctionRef(s);

forwarder.Tell("hello");
ExpectMsg(new Forwarded("hello", TestActor));
await ExpectMsgAsync(new Forwarded("hello", TestActor));
}

[Fact]
public void FunctionRef_created_by_top_level_actor_must_be_watchable()
public async Task FunctionRef_created_by_top_level_actor_must_be_watchable()
{
var s = SuperActor();
var forwarder = GetFunctionRef(s);

s.Tell(new GetForwarder(TestActor));
var f = ExpectMsg<FunctionRef>();
var f = await ExpectMsgAsync<FunctionRef>();
Watch(f);
s.Tell(new DropForwarder(f));
ExpectTerminated(f);
await ExpectTerminatedAsync(f);
}

[Fact]
public void FunctionRef_created_by_top_level_actor_must_be_able_to_watch()
public async Task FunctionRef_created_by_top_level_actor_must_be_able_to_watch()
{
var s = SuperActor();
var forwarder = GetFunctionRef(s);
var forwarder = await GetFunctionRef(s);

s.Tell(new GetForwarder(TestActor));
var f = ExpectMsg<FunctionRef>();
var f = await ExpectMsgAsync<FunctionRef>();
forwarder.Watch(f);
s.Tell(new DropForwarder(f));
ExpectMsg(new Forwarded(new Terminated(f, true, false), f));
await ExpectMsgAsync(new Forwarded(new Terminated(f, true, false), f));
}

[Fact]
public void FunctionRef_created_by_top_level_actor_must_terminate_when_their_parent_terminates()
public async Task FunctionRef_created_by_top_level_actor_must_terminate_when_their_parent_terminates()
{
var s = SuperActor();
var forwarder = GetFunctionRef(s);
var forwarder = await GetFunctionRef(s);

Watch(forwarder);
s.Tell(PoisonPill.Instance);
ExpectTerminated(forwarder);
await ExpectTerminatedAsync(forwarder);
}

private FunctionRef GetFunctionRef(IActorRef s)
private async Task<FunctionRef> GetFunctionRef(IActorRef s)
{
s.Tell(new GetForwarder(TestActor));
return ExpectMsg<FunctionRef>();
return await ExpectMsgAsync<FunctionRef>();
}

private IActorRef SuperActor() => Sys.ActorOf(Props.Create<Super>(), "super");
Expand All @@ -186,67 +187,67 @@ private FunctionRef GetFunctionRef(IActorRef s)
#region non-top level

[Fact]
public void FunctionRef_created_by_non_top_level_actor_must_forward_messages()
public async Task FunctionRef_created_by_non_top_level_actor_must_forward_messages()
{
var s = SupSuperActor();
var forwarder = GetFunctionRef(s);
var forwarder = await GetFunctionRef(s);

forwarder.Tell("hello");
ExpectMsg(new Forwarded("hello", TestActor));
await ExpectMsgAsync(new Forwarded("hello", TestActor));
}

[Fact]
public void FunctionRef_created_by_non_top_level_actor_must_be_watchable()
public async Task FunctionRef_created_by_non_top_level_actor_must_be_watchable()
{
var s = SupSuperActor();
var forwarder = GetFunctionRef(s);
var forwarder = await GetFunctionRef(s);

s.Tell(new GetForwarder(TestActor));
var f = ExpectMsg<FunctionRef>();
var f = await ExpectMsgAsync<FunctionRef>();
Watch(f);
s.Tell(new DropForwarder(f));
ExpectTerminated(f);
await ExpectTerminatedAsync(f);
}

[Fact]
public void FunctionRef_created_by_non_top_level_actor_must_be_able_to_watch()
public async Task FunctionRef_created_by_non_top_level_actor_must_be_able_to_watch()
{
var s = SupSuperActor();
var forwarder = GetFunctionRef(s);
var forwarder = await GetFunctionRef(s);

s.Tell(new GetForwarder(TestActor));
var f = ExpectMsg<FunctionRef>();
var f = await ExpectMsgAsync<FunctionRef>();
forwarder.Watch(f);
s.Tell(new DropForwarder(f));
ExpectMsg(new Forwarded(new Terminated(f, true, false), f));
await ExpectMsgAsync(new Forwarded(new Terminated(f, true, false), f));
}

[Fact]
public void FunctionRef_created_by_non_top_level_actor_must_terminate_when_their_parent_terminates()
public async Task FunctionRef_created_by_non_top_level_actor_must_terminate_when_their_parent_terminates()
{
var s = SupSuperActor();
var forwarder = GetFunctionRef(s);
var forwarder = await GetFunctionRef(s);

Watch(forwarder);
s.Tell(PoisonPill.Instance);
ExpectTerminated(forwarder);
await ExpectTerminatedAsync(forwarder);
}

private IActorRef SupSuperActor() => Sys.ActorOf(Props.Create<SupSuper>(), "supsuper");

#endregion

[Fact(Skip = "FIXME")]
public void FunctionRef_when_not_registered_must_not_be_found()
public async Task FunctionRef_when_not_registered_must_not_be_found()
{
var provider = ((ExtendedActorSystem)Sys).Provider;
var fref = new FunctionRef(TestActor.Path / "blabla", provider, Sys.EventStream, (x, y) => { });
EventFilter.Exception<InvalidOperationException>().ExpectOne(() =>
await EventFilter.Exception<InvalidOperationException>().ExpectOneAsync(async() =>
{
// needs to be something that fails when the deserialized form is not a FunctionRef
// this relies upon serialize-messages during tests
TestActor.Tell(new DropForwarder(fref));
ExpectNoMsg(TimeSpan.FromSeconds(1));
await ExpectNoMsgAsync(TimeSpan.FromSeconds(1));
});
}
}
Expand Down