Skip to content

Port Akka.Tests.Actor tests to async/await - ActorSystemSpec #5766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 28, 2022
Merged

Port Akka.Tests.Actor tests to async/await - ActorSystemSpec #5766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4d806fe
Port `Akka.Tests.Actor` tests to async/await - `ActorSystemSpec`
eaba Mar 28, 2022
5b0121f
Merge branch 'feature/async_testkit' into actor_system_dispatcher_spec
eaba Mar 28, 2022
00508f8
Replaced `Wait` with `AwaitWithTimeout`
eaba Mar 28, 2022
31a5001
Fix unit tests
Arkatufus Mar 28, 2022
5e4e97f
Merge branch 'feature/async_testkit' into actor_system_dispatcher_spec
Arkatufus Mar 28, 2022
b61f36a
Merge branch 'feature/async_testkit' into actor_system_dispatcher_spec
Arkatufus Mar 28, 2022
b0fec1f
Merge branch 'feature/async_testkit' into actor_system_dispatcher_spec
Arkatufus Mar 28, 2022
b83b32c
Merge branch 'feature/async_testkit' into actor_system_dispatcher_spec
Arkatufus Mar 28, 2022
7849b5a
Merge branch 'feature/async_testkit' into actor_system_dispatcher_spec
Arkatufus Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/Akka.Tests/Actor/ActorSystemDispatcherSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public ActorSystemDispatcherSpec(ITestOutputHelper output):base(output, Config)
{ }

[Fact]
public void The_ActorSystem_must_not_use_passed_in_SynchronizationContext_if_executor_is_configured_in()
public async Task The_ActorSystem_must_not_use_passed_in_SynchronizationContext_if_executor_is_configured_in()
{
var config =
ConfigurationFactory.ParseString("akka.actor.default-dispatcher.executor = fork-join-executor")
Expand All @@ -49,7 +49,7 @@ public void The_ActorSystem_must_not_use_passed_in_SynchronizationContext_if_exe

actor.Tell("ping", probe);

probe.ExpectMsg("ping", TimeSpan.FromSeconds(1));
await probe.ExpectMsgAsync("ping", TimeSpan.FromSeconds(1));
}
finally
{
Expand Down
55 changes: 28 additions & 27 deletions src/core/Akka.Tests/Actor/ActorSystemSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
using Akka.Dispatch;
using Akka.Event;
using FluentAssertions.Execution;
using Akka.Tests.Util;

namespace Akka.Tests.Actor
{
Expand Down Expand Up @@ -63,7 +64,7 @@ public void Reject_invalid_names()
/// }
/// </summary>
[Fact]
public void Logs_config_on_start_with_info_level()
public async Task Logs_config_on_start_with_info_level()
{
var config = ConfigurationFactory.ParseString("akka.log-config-on-start = on")
.WithFallback(DefaultConfig);
Expand All @@ -76,13 +77,13 @@ public void Logs_config_on_start_with_info_level()

// Notice here we forcedly start actor system again to monitor how it processes
var expected = "log-config-on-start : on";
eventFilter.Info(contains:expected).ExpectOne(() => system.Start());
await eventFilter.Info(contains:expected).ExpectOneAsync(() => system.Start());

system.Terminate();
await system.Terminate();
}

[Fact]
public void Does_not_log_config_on_start()
public async Task Does_not_log_config_on_start()
{
var config = ConfigurationFactory.ParseString("akka.log-config-on-start = off")
.WithFallback(DefaultConfig);
Expand All @@ -94,21 +95,21 @@ public void Does_not_log_config_on_start()
var eventFilter = new EventFilterFactory(new TestKit.Xunit2.TestKit(system));

// Notice here we forcedly start actor system again to monitor how it processes
eventFilter.Info().Expect(0, () => system.Start());
await eventFilter.Info().ExpectAsync(0, () => system.Start());

system.Terminate();
await system.Terminate();
}

[Fact]
public void Allow_valid_names()
public async Task Allow_valid_names()
{
ActorSystem
await ActorSystem
.Create("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-")
.Terminate();
}

[Fact]
public void Log_dead_letters()
public async Task Log_dead_letters()
{
var sys = ActorSystem.Create("LogDeadLetters", ConfigurationFactory.ParseString("akka.loglevel=INFO")
.WithFallback(DefaultConfig));
Expand All @@ -118,7 +119,7 @@ public void Log_dead_letters()
var a = sys.ActorOf(Props.Create<Terminater>());

var eventFilter = new EventFilterFactory(new TestKit.Xunit2.TestKit(sys));
eventFilter.Info(contains: "not delivered").Expect(1, () =>
await eventFilter.Info(contains: "not delivered").ExpectAsync(1, () =>
{
a.Tell("run");
a.Tell("boom");
Expand All @@ -128,25 +129,25 @@ public void Log_dead_letters()
}

[Fact]
public void Block_until_exit()
public async Task Block_until_exit()
{
var actorSystem = ActorSystem
.Create(Guid.NewGuid().ToString());
var st = Stopwatch.StartNew();
var asyncShutdownTask = Task.Delay(TimeSpan.FromSeconds(1)).ContinueWith(_ => actorSystem.Terminate());
actorSystem.WhenTerminated.Wait(TimeSpan.FromSeconds(2)).ShouldBeTrue();
(await actorSystem.WhenTerminated.AwaitWithTimeout(TimeSpan.FromSeconds(2))).ShouldBeTrue();
Assert.True(st.Elapsed.TotalSeconds >= .9);
}

[Fact]
public void Given_a_system_that_isnt_going_to_shutdown_When_waiting_for_system_shutdown_Then_it_times_out()
public async Task Given_a_system_that_isnt_going_to_shutdown_When_waiting_for_system_shutdown_Then_it_times_out()
{
var actorSystem = ActorSystem.Create(Guid.NewGuid().ToString());
actorSystem.WhenTerminated.Wait(TimeSpan.FromMilliseconds(10)).ShouldBeFalse();
(await actorSystem.WhenTerminated.AwaitWithTimeout(TimeSpan.FromMilliseconds(10))).ShouldBeFalse();
}

[Fact]
public void Run_termination_callbacks_in_order()
public async Task Run_termination_callbacks_in_order()
{
var actorSystem = ActorSystem.Create(Guid.NewGuid().ToString());
var result = new List<int>();
Expand All @@ -167,7 +168,7 @@ public void Run_termination_callbacks_in_order()
});
}

actorSystem.Terminate();
await actorSystem.Terminate();
latch.Ready();

expected.Reverse();
Expand All @@ -176,7 +177,7 @@ public void Run_termination_callbacks_in_order()
}

[Fact]
public void AwaitTermination_after_termination_callbacks()
public async Task AwaitTermination_after_termination_callbacks()
{
var actorSystem = ActorSystem.Create(Guid.NewGuid().ToString());
var callbackWasRun = false;
Expand All @@ -193,40 +194,40 @@ public void AwaitTermination_after_termination_callbacks()
actorSystem.Terminate();
});

actorSystem.WhenTerminated.Wait(TimeSpan.FromSeconds(5));
await actorSystem.WhenTerminated.AwaitWithTimeout(TimeSpan.FromSeconds(5));
Assert.True(callbackWasRun);
}

[Fact]
public void Throw_exception_when_register_callback_after_shutdown()
public async Task Throw_exception_when_register_callback_after_shutdown()
{
var actorSystem = ActorSystem.Create(Guid.NewGuid().ToString());

actorSystem.Terminate().Wait(TimeSpan.FromSeconds(10));
await actorSystem.Terminate().AwaitWithTimeout(TimeSpan.FromSeconds(10));

var ex = Assert.Throws<InvalidOperationException>(() => actorSystem.RegisterOnTermination(() => { }));
Assert.Equal("ActorSystem already terminated.", ex.Message);
}

[Fact]
public void Reliably_create_waves_of_actors()
public async Task Reliably_create_waves_of_actors()
{
var timeout = Dilated(TimeSpan.FromSeconds(20));
var waves = Task.WhenAll(
Sys.ActorOf(Props.Create<Wave>()).Ask<string>(50000),
Sys.ActorOf(Props.Create<Wave>()).Ask<string>(50000),
Sys.ActorOf(Props.Create<Wave>()).Ask<string>(50000));

waves.Wait(timeout.Duration() + TimeSpan.FromSeconds(5));
await waves.AwaitWithTimeout(timeout.Duration() + TimeSpan.FromSeconds(5));

Assert.Equal(new[] { "done", "done", "done" }, waves.Result);
}

[Fact]
public void Find_actors_that_just_have_been_created()
public async Task Find_actors_that_just_have_been_created()
{
Sys.ActorOf(Props.Create(() => new FastActor(new TestLatch(), TestActor)).WithDispatcher("slow"));
Assert.Equal(typeof(LocalActorRef), ExpectMsg<Type>());
Assert.Equal(typeof(LocalActorRef), await ExpectMsgAsync<Type>());
}

[Fact()]
Expand Down Expand Up @@ -313,7 +314,7 @@ public void Support_using_a_custom_scheduler()
}

[Fact]
public void Allow_configuration_of_guardian_supervisor_strategy()
public async Task Allow_configuration_of_guardian_supervisor_strategy()
{
var config = ConfigurationFactory.ParseString("akka.actor.guardian-supervisor-strategy=\"Akka.Actor.StoppingSupervisorStrategy\"")
.WithFallback(DefaultConfig);
Expand All @@ -330,12 +331,12 @@ public void Allow_configuration_of_guardian_supervisor_strategy()

a.Tell("die");

var t = probe.ExpectTerminated(a);
var t = await probe.ExpectTerminatedAsync(a);

Assert.True(t.ExistenceConfirmed);
Assert.False(t.AddressTerminated);

system.Terminate();
await system.Terminate();
}

[Fact]
Expand Down