Skip to content

Port Akka.Tests.Actor tests to async/await - ProducerPipeline #5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Port Akka.Tests.Actor tests to async/await - ProducerPipeline #5762

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a4f539
Port `Akka.Tests.Actor` tests to `async/await` - `ProducerPipeline`
eaba Mar 25, 2022
22cbc9b
Merge branch 'feature/async_testkit' into actor_producer_pipeline_tests
Arkatufus Mar 28, 2022
fceb344
Merge branch 'feature/async_testkit' into actor_producer_pipeline_tests
Arkatufus Mar 28, 2022
bddaa79
Merge branch 'feature/async_testkit' into actor_producer_pipeline_tests
Arkatufus Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions src/core/Akka.Tests/Actor/ActorProducerPipelineTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

using System;
using System.Collections.Generic;
using System.Threading.Tasks;
using Akka.Actor;
using Akka.TestKit;
using Xunit;
Expand Down Expand Up @@ -126,17 +127,17 @@ public ActorProducerPipelineTests()
}

[Fact]
public void Pipeline_application_should_survive_internal_plugin_exceptions()
public async Task Pipeline_application_should_survive_internal_plugin_exceptions()
{
_resolver.Register(new FailingPlugin());
_resolver.Register(new WorkingPlugin());

EventFilter.Exception<TestException>("plugin failed").ExpectOne(() =>
await EventFilter.Exception<TestException>("plugin failed").ExpectOneAsync(async () =>
{
var actor = ActorOf<PlugActor>();
var ask = actor.Ask<string[]>("plugins", TimeSpan.FromSeconds(1));
var ask = await actor.Ask<string[]>("plugins", TimeSpan.FromSeconds(1));

ask.Result.ShouldOnlyContainInOrder("failing plugin", "working plugin");
ask.ShouldOnlyContainInOrder("failing plugin", "working plugin");
});
}

Expand All @@ -152,7 +153,7 @@ public void Pipeline_should_not_allow_to_register_the_same_plugin_twice()
}

[Fact]
public void Pipeline_should_allow_to_register_multiple_generic_plugins_with_different_generic_types()
public async Task Pipeline_should_allow_to_register_multiple_generic_plugins_with_different_generic_types()
{
_resolver.Register(new WorkingPlugin()).ShouldBeTrue();
_resolver.Register(new GenericPlugin<PlugActorA>()).ShouldBeTrue();
Expand All @@ -161,34 +162,34 @@ public void Pipeline_should_allow_to_register_multiple_generic_plugins_with_diff
var plugA = ActorOf<PlugActorA>();
var plugB = ActorOf<PlugActorB>();

plugA.Ask<string[]>("plugins", TimeSpan.FromSeconds(3)).Result.ShouldOnlyContainInOrder("working plugin", typeof(PlugActorA).ToString());
plugB.Ask<string[]>("plugins", TimeSpan.FromSeconds(3)).Result.ShouldOnlyContainInOrder("working plugin", typeof(PlugActorB).ToString());
(await plugA.Ask<string[]>("plugins", TimeSpan.FromSeconds(3))).ShouldOnlyContainInOrder("working plugin", typeof(PlugActorA).ToString());
(await plugB.Ask<string[]>("plugins", TimeSpan.FromSeconds(3))).ShouldOnlyContainInOrder("working plugin", typeof(PlugActorB).ToString());
}

[Fact]
public void Pipeline_application_should_apply_plugins_in_specified_order()
public async Task Pipeline_application_should_apply_plugins_in_specified_order()
{
_resolver.Insert(0, new OrderedPlugin1()).ShouldBeTrue();
_resolver.Insert(2, new OrderedPlugin3()).ShouldBeTrue();
_resolver.Insert(1, new OrderedPlugin2()).ShouldBeTrue();

var actor = ActorOf<PlugActor>();
actor.Ask<string[]>("plugins", TimeSpan.FromSeconds(3)).Result.ShouldOnlyContainInOrder("plugin-1", "plugin-2", "plugin-3");
(await actor.Ask<string[]>("plugins", TimeSpan.FromSeconds(3))).ShouldOnlyContainInOrder("plugin-1", "plugin-2", "plugin-3");
}

[Fact]
public void DefaultPipeline_should_apply_stashing_to_actors_implementing_it()
public async Task DefaultPipeline_should_apply_stashing_to_actors_implementing_it()
{
var actor = ActorOf<StashingActor>();
actor.Ask<string>(StashStatus.Instance, TimeSpan.FromSeconds(3)).Result.ShouldBe("actor stash is initialized");
(await actor.Ask<string>(StashStatus.Instance, TimeSpan.FromSeconds(3))).ShouldBe("actor stash is initialized");
}

[Fact]
public void DefaultPipeline_should_unstash_all_terminated_actors_stashed_messages_on_stop()
public async Task DefaultPipeline_should_unstash_all_terminated_actors_stashed_messages_on_stop()
{
// we'll send 3 int messages to stash by the actor and then stop it,
// all stashed messages should then be unstashed back and sent to dead letters
EventFilter.DeadLetter<int>().Expect(3, () =>
await EventFilter.DeadLetter<int>().ExpectAsync(3, () =>
{
var actor = ActorOf<StashingActor>();
// send some messages to stash
Expand Down