Skip to content

[Docs]: Fix Metadata Reference #5668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2022
Merged

[Docs]: Fix Metadata Reference #5668

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6e4279
Turn on `ProduceReferenceAssembly`
eaba Feb 17, 2022
555b7cd
Add `ProduceReferenceAssembly` to `common.props`
eaba Feb 17, 2022
e2a4773
Fix build failures in Akka.FSharp
eaba Feb 17, 2022
1d96e39
Revert `<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</Produc…
eaba Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
<NetFrameworkTestVersion>net471</NetFrameworkTestVersion>
<NetStandardLibVersion>netstandard2.0</NetStandardLibVersion>
<FluentAssertionsVersion>5.10.3</FluentAssertionsVersion>
<ProduceReferenceAssembly>true</ProduceReferenceAssembly>
<FsCheckVersion>2.16.3</FsCheckVersion>
<HoconVersion>2.0.3</HoconVersion>
<ConfigurationManagerVersion>4.7.0</ConfigurationManagerVersion>
Expand Down
1 change: 1 addition & 0 deletions src/contrib/cluster/Akka.Cluster.Metrics/Akka.Cluster.Metrics.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
and to the registered subscribers on the system event bus with the help of Cluster Metrics Extension.
</Description>
<TargetFramework>$(NetStandardLibVersion)</TargetFramework>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to revert all of these if we're already doing this in common.props

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need that there right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, common.props gives us a single place to manage these. We only need them in the F# projects for override.

<PackageTags>$(AkkaPackageTags);network;cluster;sharding</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions src/contrib/cluster/Akka.Cluster.Sharding/Akka.Cluster.Sharding.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Description>Sharded actors with managed lifecycle for Akka.NET cluster</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);network;cluster;sharding</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/contrib/cluster/Akka.Cluster.Tools/Akka.Cluster.Tools.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);network;cluster</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/contrib/cluster/Akka.DistributedData.LightningDB/Akka.DistributedData.LightningDB.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Description>Replicated data using CRDT structures</Description>
<TargetFramework>$(NetStandardLibVersion)</TargetFramework>
<PackageTags>$(AkkaPackageTags);network;cluster;crdt;replication;lightningdb;lmdb</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/contrib/cluster/Akka.DistributedData/Akka.DistributedData.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Description>Replicated data using CRDT structures</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);network;cluster;crdt;replication</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/contrib/dependencyinjection/Akka.DI.TestKit/Akka.DI.TestKit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Description>Dependency Injection (DI) TestKit support for Akka.NET</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);dependency injection;testkit</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/contrib/persistence/Akka.Persistence.Query.Sql/Akka.Persistence.Query.Sql.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Description>Akka.NET streams support for ADO.NET Persistence middleware.</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);persistence;eventsource;sql;reactive;streams</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/contrib/persistence/Akka.Persistence.Sql.Common/Akka.Persistence.Sql.Common.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);persistence;eventsource;sql</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/contrib/persistence/Akka.Persistence.Sql.TestKit/Akka.Persistence.Sql.TestKit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Description>Akka.NET TestKit for SQL-based ADO.NET Persistence middleware</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);persistence;testkit;eventsource;sql;reactive;streams</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/contrib/serializers/Akka.Serialization.TestKit/Akka.Serialization.TestKit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<TargetFrameworks>$(NetFrameworkTestVersion);$(NetTestVersion);$(NetCoreTestVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);hyperion;serializer;serialize;testkit</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/contrib/testkits/Akka.TestKit.Xunit2/Akka.TestKit.Xunit2.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Description>TestKit for writing tests for Akka.NET using xUnit.</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);testkit;xunit</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Cluster.TestKit/Akka.Cluster.TestKit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);network;cluster;testkit</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Cluster/Akka.Cluster.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Description>Cluster support for Akka.NET</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);network;cluster</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Coordination/Akka.Coordination.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Description>Distributed coordination support for Akka.NET</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags)</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
3 changes: 2 additions & 1 deletion src/core/Akka.FSharp.Tests/Akka.FSharp.Tests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

<PropertyGroup>
<AssemblyTitle>Akka.FSharp.Tests</AssemblyTitle>
<TargetFrameworks>$(NetFrameworkTestVersion);$(NetTestVersion);$(NetCoreTestVersion)</TargetFrameworks>
<TargetFrameworks>$(NetCoreTestVersion)</TargetFrameworks>
<ProduceReferenceAssembly>false</ProduceReferenceAssembly>
<IsPackable>false</IsPackable>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.FSharp/Akka.FSharp.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);F#;fsharp</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<ProduceReferenceAssembly>false</ProduceReferenceAssembly>
<NoWarn></NoWarn>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Persistence.FSharp/Akka.Persistence.FSharp.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>akka;actors;actor model;Akka;concurrency;F#;Fsharp;persistence;eventsource</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<ProduceReferenceAssembly>false</ProduceReferenceAssembly>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Persistence.Query/Akka.Persistence.Query.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);persistence;eventsource;query;stream</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Persistence.TCK/Akka.Persistence.TCK.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);persistence;eventsource;tck</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Persistence/Akka.Persistence.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<Description>Persistence actor support for Akka.NET</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);persistence;eventsource</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>
<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Remote.TestKit/Akka.Remote.TestKit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Description>TestKit for Testing Distributed Akka.NET Applications</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);network;testkit</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Remote/Akka.Remote.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<Description>Remote actor support for Akka.NET</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);network</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>
<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Streams.TestKit/Akka.Streams.TestKit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Description>Testkit for Reactive stream support for Akka.NET</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);reactive;stream;testkit</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Streams/Akka.Streams.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags);reactive;stream</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
</PropertyGroup>
<ItemGroup>
<EmbeddedResource Include="reference.conf" />
Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.TestKit/Akka.TestKit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Description>You need a Akka.TestKit.* package! Add the one appropriate for the test framework you use instead. For example: Akka.TestKit.Xunit or Akka.TestKit.VsTest. This package only contains base functionality for writing tests for the Akka.NET framework.</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<PackageTags>$(AkkaPackageTags)</PackageTags>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/core/Akka.Tests.Shared.Internals/Akka.Tests.Shared.Internals.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<Import Project="..\..\common.props" />
<PropertyGroup>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/core/Akka/Akka.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<AssemblyTitle>Akka</AssemblyTitle>
<Description>Akka.NET is a port of the popular Java/Scala framework Akka to .NET</Description>
<TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks>
<ProduceReferenceAssembly>$(ProduceReferenceAssembly)</ProduceReferenceAssembly>
<PackageTags>$(AkkaPackageTags)</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<LangVersion>7.2</LangVersion>
Expand Down