-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Description
FluentAssertion's commercial license change is a problem for us. Now as an OSS project, we don't technically have to pay for a license on the commercial versions (8+) - which is fine. But, our customers who use the TestKit now consume a FluentAssertions dependency transitively due to our decision we made in the v1.5 release pipeline here: #5432
I'm not cool with passing that risk onto end-users, so I think we should remove all FluentAssertions usage from the TestKits (AND we should probably make some steps to remove our usage of it from the project in general, but this is like a 1000000x lower priority than removing it from the TestKit.)
TestKits
Remove FA from all base class methods and remove it as a dependency.
- Akka.TestKit.Nunit (does not contain reference to FA)
- Akka.Hosting.TestKit
- Akka.Serialization.TestKit
Tests
The tests are a much bigger issue due to sheer surface area involved and honestly, it's probably not a high priority, but we want to slam the gate shut on someone reintroducing it or anything like it back into the TestKit.
I've used this for all of the our xUnit-based tests in some other projects before and it worked pretty well https://github.com/amoerie/fluentassertions-migrator - not 100%, but let's say 80-90%
Sub-issues
Metadata
Metadata
Assignees
Labels
Type
Projects
Status