Add missing using keyword in snapshot-store DAO #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory leak caused by
CancellationTokenSourcehas been observed in the snapshot store DAO.Changes
Add missing
usingkeyword inByteArraySnapshotDaoto make sure that allCancellationTokenSourceare disposed properly.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksBenchmark was done by continuously creating new
ReceivePersistentActorat the rate of 50 actors per second for 5 minutes. Memory snapshot were taken using Jetbrains DotMemory using API before and after the actor creation spam and were compared to check for memory leak.This PR's Benchmarks