Skip to content

Fix GetSnapshotCollection creating new collection on every invocation #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Fix GetSnapshotCollection creating new collection on every invocation #402

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fecdd44
Fix GetSnapshotCollection creating new collection on every invocation
Arkatufus Feb 26, 2025
6c305b8
Merge branch 'dev' into fix-snapshot-performance-problem
Arkatufus Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions src/Akka.Persistence.MongoDb/Snapshot/MongoDbSnapshotStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,19 +107,22 @@ private IMongoDatabase GetMongoDb()

private async Task<IMongoCollection<SnapshotEntry>> GetSnapshotCollection(CancellationToken token)
{
_snapshotCollection_DoNotUseDirectly = GetMongoDb().GetCollection<SnapshotEntry>(_settings.Collection);

if (!_settings.AutoInitialize)
if (_snapshotCollection_DoNotUseDirectly is not null)
return _snapshotCollection_DoNotUseDirectly;

var modelWithAscendingPersistenceIdAndDescendingSequenceNr =
new CreateIndexModel<SnapshotEntry>(Builders<SnapshotEntry>.IndexKeys
.Ascending(entry => entry.PersistenceId)
.Descending(entry => entry.SequenceNr));

await _snapshotCollection_DoNotUseDirectly.Indexes
.CreateOneAsync(modelWithAscendingPersistenceIdAndDescendingSequenceNr,
cancellationToken: token);
_snapshotCollection_DoNotUseDirectly = GetMongoDb().GetCollection<SnapshotEntry>(_settings.Collection);

if (_settings.AutoInitialize)
{
var modelWithAscendingPersistenceIdAndDescendingSequenceNr =
new CreateIndexModel<SnapshotEntry>(Builders<SnapshotEntry>.IndexKeys
.Ascending(entry => entry.PersistenceId)
.Descending(entry => entry.SequenceNr));

await _snapshotCollection_DoNotUseDirectly.Indexes
.CreateOneAsync(modelWithAscendingPersistenceIdAndDescendingSequenceNr,
cancellationToken: token);
}

return _snapshotCollection_DoNotUseDirectly;
}
Expand Down
Loading