Health Checks: made it easier to customize failureSTate and tags for all health checks
#682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
added a commit
to Aaronontheweb/Akka.Hosting
that referenced
this pull request
Oct 25, 2025
…tern Updated AkkaPersistenceJournalBuilder and AkkaPersistenceSnapshotBuilder to use optional parameters instead of method overloads, following the pattern established in PR akkadotnet#682 for consistency across the codebase. Changes: - Removed separate overloads for WithHealthCheck() methods - Added optional 'tags' parameter to existing methods - Updated API approval tests to reflect new signatures - All tests pass successfully
Aaronontheweb
added a commit
that referenced
this pull request
Oct 25, 2025
* Add customizable tags parameter to health check methods Implements issue #679: Allow users to customize tags for health checks via optional parameter. - Added optional `tags` parameter to AkkaPersistenceJournalBuilder.WithHealthCheck() - Added optional `tags` parameter to AkkaPersistenceSnapshotBuilder.WithHealthCheck() - When tags parameter is null, defaults to ["akka", "persistence", "journal"] or ["akka", "persistence", "snapshot-store"] - Consolidates previous overloads into single method with all optional parameters to avoid ambiguity - All 18 health check tests pass * Approve new WithHealthCheck overload API signatures * Refactor persistence health check APIs to match PR #682 pattern Updated AkkaPersistenceJournalBuilder and AkkaPersistenceSnapshotBuilder to use optional parameters instead of method overloads, following the pattern established in PR #682 for consistency across the codebase. Changes: - Removed separate overloads for WithHealthCheck() methods - Added optional 'tags' parameter to existing methods - Updated API approval tests to reflect new signatures - All tests pass successfully
3 tasks
This was referenced Oct 27, 2025
This was referenced Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Minor API change, but it should make it easier for users to customize tags and failure status on all health checks
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):