fix: emit equal when needed - alternative to #1853 #1922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
reviewed
Mar 22, 2022
epoberezkin
reviewed
Mar 22, 2022
This was referenced May 22, 2024
This was referenced Jun 25, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve? #1852
What changes did you make? I have implemented the code based on what was suggested by @epoberezkin in #1853
Is there anything that requires more attention while reviewing?
I was facing similar issue #1852 that was raised by @cscheid. Since #1853 has not been closed and was left open with the comment by @epoberezkin, I thought of raising this PR with what was suggested.