Skip to content

[source-google-ads] : Implement hybrid customer partition router #64559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

iberchid
Copy link
Contributor

@iberchid iberchid commented Aug 8, 2025

What

#64136

How

  • Implement HybridCustomerPartitionRouter which takes into account the list of customer ids if provided in the config, with a fallback to parent stream partitioning logic using SubstreamPartitionRouter
  • Restore login-customer-id in the spec, which is needed for the case where customer_id is provided in the config

User Impact

  • No impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link
Contributor

github-actions bot commented Aug 8, 2025

👋 Welcome to Airbyte!

Thank you for your contribution from iberchid/airbyte! We're excited to have you in the Airbyte community.

Helpful Resources

PR Slash Commands

As needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
  • /run-connector-tests - Runs connector tests.
  • /run-cat-tests - Runs CAT tests.
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).

If you have any questions, feel free to ask in the PR comments or join our Slack community.

Tips for Working with CI

  1. Pre-Release Checks. Please pay attention to these, as they contain standard checks on the metadata.yaml file, docs requirements, etc. If you need help resolving a pre-release check, please ask a maintainer.
    • Note: If you are creating a new connector, please be sure to replace the default logo.svg file with a suitable icon.
  2. Connector CI Tests. Some failures here may be expected if your tests require credentials. Please review these results to ensure (1) unit tests are passing, if applicable, and (2) integration tests pass to the degree possible and expected.
  3. (Optional.) BYO Connector Credentials for tests in your fork. You can optionally set up your fork with BYO credentials for your connector. This can significantly speed up your review, ensuring your changes are fully tested before the maintainers begin their review.

@iberchid iberchid force-pushed the iberchid/update_google_ads_connector branch from 36c1147 to 2492ec0 Compare August 12, 2025 08:20
@iberchid iberchid changed the title [source-google-ads] : Upgrade API version and implement hybrid customer partition router [source-google-ads] : Implement hybrid customer partition router Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants