Support Libressl #537
Merged
Support Libressl #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI we are considering dropping the C code here in PR #457 |
|
@jlaine well, I've used this patch to make OpenBSD port anyway and I think that better to backport to upstream patches. |
jlaine
reviewed
Jul 23, 2024
| ) | ||
| ) | ||
|
|
||
| @skipIf("ed448" in SKIP_TESTS, "Skipping ed448 tests") |
There was a problem hiding this comment.
I think I don't understand your question. Can I ask you to rephase it?
jlaine
reviewed
Jul 23, 2024
| *generate_ed25519_certificate(common_name="example.com") | ||
| ) | ||
|
|
||
| def test_handshake_with_ed448_certificate(self): |
There was a problem hiding this comment.
Why not use the same skipIf("ed448" in SKIP_TESTS) as above?
There was a problem hiding this comment.
Indeed it make things cleaner
|
@jlaine and ping here as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here a small changes which allows to build and run aioquick against LibreSSL