Skip to content

Fix Ref Leak #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 8, 2025
Merged

Fix Ref Leak #162

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
40b0f4a
Remove incref
Vizonex Oct 8, 2025
ea542da
Create 162.bugfix.rst
Vizonex Oct 8, 2025
1292d2e
Update 162.bugfix.rst
Vizonex Oct 8, 2025
546095a
Remove incref from cached_property
Vizonex Oct 8, 2025
ae7fede
cleanuup changelog
bdraco Oct 8, 2025
0f72251
remove unused
bdraco Oct 8, 2025
6ecf6d6
remove 1 ref from PyObject_CallOneArg
Vizonex Oct 8, 2025
fc00ef6
shift Py_DECREF to after PyDict_SetItem
Vizonex Oct 8, 2025
4aa67ba
test
bdraco Oct 8, 2025
9e23e07
test
bdraco Oct 8, 2025
f8c0e1c
test
bdraco Oct 8, 2025
416fea6
test
bdraco Oct 8, 2025
185cf1a
test
bdraco Oct 8, 2025
288a9dd
test
bdraco Oct 8, 2025
3b20806
comments
bdraco Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/162.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed reference leak caused by ``Py_INCREF`` because Cython has its own reference counter systems -- by :user:`Vizonex`.
4 changes: 0 additions & 4 deletions src/propcache/_helpers_c.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ cdef class under_cached_property:
if val == NULL:
val = PyObject_CallOneArg(self.wrapped, inst)
PyDict_SetItem(cache, self.name, val)
else:
Py_INCREF(val)
return <object>val

def __set__(self, inst, value):
Expand Down Expand Up @@ -97,8 +95,6 @@ cdef class cached_property:
if val is NULL:
val = PyObject_CallOneArg(self.func, inst)
PyDict_SetItem(cache, self.name, val)
else:
Py_INCREF(val)
return <object>val

__class_getitem__ = classmethod(GenericAlias)
Loading