Add arm64 windows wheel builds #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
|
@finnagin Looks good. More wheels are definitely needed. I recently had someone add these to winloop recently too. If I was able to review this code (which I don't know if I have permission to do so) I would've done so. |
webknjaz
reviewed
Aug 11, 2025
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
webknjaz
reviewed
Aug 11, 2025
webknjaz
reviewed
Aug 11, 2025
webknjaz
reviewed
Aug 11, 2025
Adds workaround until actionlint includes windows-11-arm in list of valid `runs-on` options
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
To explain that python versions are skipped here because setup-python only supports 3.11+ on arm64 windows
Vizonex
suggested changes
Aug 11, 2025
Vizonex
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for building ARM64 wheels on Windows by updating the CI/CD pipeline to include windows-11-arm as a runner option. The changes enable native wheel distribution for ARM64 Windows users.
- Added
windows-11-armrunner to the build matrix for both wheel building and testing workflows - Modified the reusable workflow to support OS values without the
-latestsuffix - Added actionlint configuration to recognize the new runner type
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CHANGES/133.contrib.rst | Documents the addition of ARM64 Windows wheel builds |
| .github/workflows/reusable-build-wheel.yml | Removes automatic -latest suffix to support windows-11-arm runner |
| .github/workflows/ci-cd.yml | Adds windows-11-arm to build and test matrices with appropriate exclusions |
| .github/actionlint.yml | Configures actionlint to recognize windows-11-arm as a valid runner |
|
Plz ignore copilot. I was just curious what it'd produce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This would add wheel builds for arm64 Windows.
Are there changes in behavior for the user?
No, other than a native wheel would be available for arm64 Windows users.
Related issue number
Fixes #132
Checklist