Add __call__ wrappers to aiosignal along with better type hinting extensions

[Vizonex]

What do these changes do?

I'm going to start moving some of my code over from aiocallback over to this branch which I think would be acceptable given the circumstances of this proposal it was concluded that moving my things over here would allow this library to hopefully achieve a better user development experience.

Eventually I will give this library special member descriptors so that much of the works done with TraceConfig can be less bulky overall but this is the start to doing so.

Are there changes in behavior for the user?

Related issue number

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[Vizonex]

Not sure how to add typing-extension as a requirement if users are working with 3.9. Getting help with that would be appreciated.

[Vizonex]

Note: This pull request was my backup plan if things went extremely poorly. I don't expect it to happen at all.

[Dreamsorcerer]

Not sure how to add typing-extension as a requirement if users are working with 3.9. Getting help with that would be appreciated.

https://github.com/aio-libs/multidict/blob/874fc89640cc3e33ad9f5d25820d2786bb8b97a9/setup.cfg#L45-L46

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.29%. Comparing base (d7a593c) to head (261d1c1).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
+ Coverage   97.61%   99.29%   +1.67%     
==========================================
  Files           3        2       -1     
  Lines         126      142      +16     
  Branches        3       11       +8     
==========================================
+ Hits          123      141      +18     
+ Misses          2        0       -2     
  Partials        1        1              

Flag	Coverage Δ
CI-GHA	99.29% <100.00%> (+1.67%)	⬆️
MyPy	61.53% <60.00%> (+4.39%)	⬆️
OS-Linux	99.29% <100.00%> (+1.67%)	⬆️
Py-3.10.17	98.58% <92.59%> (-1.42%)	⬇️
Py-3.11.12	98.58% <92.59%> (-1.42%)	⬇️
Py-3.12.10	98.58% <92.59%> (-1.42%)	⬇️
Py-3.13.3	99.29% <100.00%> (+1.67%)	⬆️
Py-3.9.22	98.58% <92.59%> (-1.42%)	⬇️
VM-ubuntu-24.04	99.29% <96.29%> (-0.71%)	⬇️
VM-ubuntu-latest	61.53% <60.00%> (+4.39%)	⬆️
pytest	99.29% <96.29%> (-0.71%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Vizonex]

@Dreamsorcerer I removed the stub file as well and made a few suggested changes that you wanted. I think I will transform aiocallback into a member descriptor library instead so that I don't have to deprecate my end but I think once these features are added in again I can re-add aiosignal back to my library, originally I dropped usage of this library when I saw an issue that this library would be deprecated.

[Vizonex]

Does anybody know how to transform a draft back into a pull request?

[webknjaz]

I triggered the CI to see if it passes. However, I'd like those .rst extensions once the config's been updated per above.

[webknjaz]

Putting reordering components in fragment names causes makes them invalid.

[Vizonex]

I remerged both Feature commits because I don't like that this workflow will not pass we might be able to fix this afterwards but for right now. This got beyond annoying.

[Dreamsorcerer]

@Vizonex So, I'm playing with this now and trying to sort out the strict typing.

The problem is that there isn't an obvious way to actually declare the type.

e.g. This says it needs a type annotation:

aiosignal/tests/test_signals.py

Line 21 in 93c5762

signal = Signal(owner)

But, there isn't even an obvious way to declare an annotation, for even this simple case.

[Dreamsorcerer]

I think an alternative approach would be to use something like:

class _AsyncFunc(Protocol):
    def __call__(self, *args: Any, **kwargs: Any) -> Awaitable[_T]:
        ...

_AsyncFuncT = TypeVar("_AsyncFuncT", bound=_AsyncFunc)

Then hopefully we'd be able to use both Protocol and Callable as annotations:

class MyCallback(Protocol):
    def __call__(self, foo: int, *, bar: str) -> Awaitable[str]:
        ...

Signal[MyCallback]
Signal[Callable[[int], Awaitable[str]]

I've not tried it out yet.

[Vizonex]

@Dreamsorcerer Thanks for getting this pull request passed I appreciate it. Let me know when the update comes out so I can re-add this library back to my member descriptor library.

[Dreamsorcerer]

Let me know when the update comes out

We won't release it without addressing my previous comment first, and getting the strict typing working.

[Dreamsorcerer]

I think we do need 2 implementations or something here.

One with TypeVarTuple for Callable support, and another for ParamSpec.

def send(self, *args: *Ts) -> T:
def send(self, *args: P.args, **kwargs: P.kwargs) -> T:

Or, given that this is mostly going to be handling callbacks, maybe we could just do the first one and not support kwargs...