Added delay to retry connection #1014
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Is it possible to have the functionality at the user level where we can catch these network connection errors. Because even with exponential back off it will keep retrying indefinitely |
|
Sorry, my competence is not enough to propose a correct fix to the problem. The suggested change looks rather like a quick-n-dirty workaround. I hope @tvoinarovskyi finds time to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a consumer connection breaks, aiokafka goes into a loop trying to reconnect every 1ms, generating a mountain of logs. This PR introduces a delay between connection attempts with the configured
retry_backoff_msparameter.Addresses issues #496 and #830.