-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Increase allowed import time for Python 3.12/3.13 to 265 #9832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I ran a profile of the imports and did not find any one thing that was causing the import time to jump up. The bulk of the time outside of bootstrap is spent in typing.py, and since we do not want to discourage adding more typing it seems like we need to increase this.
CodSpeed Performance ReportMerging #9832 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9832 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 118 118
Lines 36148 36148
Branches 4294 4294
=======================================
Hits 35680 35680
Misses 315 315
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9833 🤖 @patchback |
(cherry picked from commit 006f407)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9834 🤖 @patchback |
(cherry picked from commit 006f407)
…ython 3.12/3.13 to 265 (#9834) Co-authored-by: J. Nick Koston <[email protected]>
…ython 3.12/3.13 to 265 (#9833) Co-authored-by: J. Nick Koston <[email protected]>
I ran a profile of the imports and did not find any one thing that was causing the import time to jump up. The bulk of the time outside of bootstrap is spent in typing.py, and since we do not want to discourage adding more typing it seems like we need to increase this.
Additional discussion in #9828 (comment)