Skip to content

Increase allowed import time for Python 3.12/3.13 to 265 #9832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 12, 2024

I ran a profile of the imports and did not find any one thing that was causing the import time to jump up. The bulk of the time outside of bootstrap is spent in typing.py, and since we do not want to discourage adding more typing it seems like we need to increase this.

Additional discussion in #9828 (comment)

Screenshot 2024-11-12 at 9 24 55 AM

I ran a profile of the imports and did not find any one thing that was
causing the import time to jump up. The bulk of the time outside of
bootstrap is spent in typing.py, and since we do not want to discourage
adding more typing it seems like we need to increase this.
@bdraco bdraco requested a review from asvetlov as a code owner November 12, 2024 15:35
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 labels Nov 12, 2024
@bdraco bdraco changed the title Increase allowed import time for 3.12/3.13 to 265 Increase allowed import time for Python 3.12/3.13 to 265 Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #9832 will not alter performance

Comparing bump_import_time (4e93d5e) with master (14fcfd4)

Summary

✅ 23 untouched benchmarks

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (14fcfd4) to head (4e93d5e).
Report is 658 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9832   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files         118      118           
  Lines       36148    36148           
  Branches     4294     4294           
=======================================
  Hits        35680    35680           
  Misses        315      315           
  Partials      153      153           
Flag Coverage Δ
CI-GHA 98.59% <ø> (ø)
OS-Linux 98.27% <ø> (ø)
OS-Windows 96.07% <ø> (ø)
OS-macOS 97.36% <ø> (+<0.01%) ⬆️
Py-3.10.11 97.20% <ø> (+<0.01%) ⬆️
Py-3.10.15 97.81% <ø> (+0.05%) ⬆️
Py-3.11.10 97.80% <ø> (ø)
Py-3.11.9 97.25% <ø> (ø)
Py-3.12.7 98.34% <ø> (-0.01%) ⬇️
Py-3.13.0 98.33% <ø> (ø)
Py-3.9.13 97.12% <ø> (ø)
Py-3.9.20 97.72% <ø> (+0.04%) ⬆️
Py-pypy7.3.16 97.29% <ø> (-0.01%) ⬇️
VM-macos 97.36% <ø> (+<0.01%) ⬆️
VM-ubuntu 98.27% <ø> (ø)
VM-windows 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 12, 2024 15:45
@bdraco bdraco merged commit 006f407 into master Nov 12, 2024
40 of 41 checks passed
@bdraco bdraco deleted the bump_import_time branch November 12, 2024 15:46
Copy link
Contributor

patchback bot commented Nov 12, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/006f4070c7f64f4aacbec2795b772bf76c4efd66/pr-9832

Backported as #9833

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 12, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/006f4070c7f64f4aacbec2795b772bf76c4efd66/pr-9832

Backported as #9834

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 12, 2024
bdraco added a commit that referenced this pull request Nov 12, 2024
…ython 3.12/3.13 to 265 (#9834)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Nov 12, 2024
…ython 3.12/3.13 to 265 (#9833)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant