Skip to content

Conversation

@Dreamsorcerer
Copy link
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.9 labels Mar 28, 2024
@codecov
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (6ec4747) to head (11cdc06).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8259   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         107      107           
  Lines       32936    32936           
  Branches     3851     3851           
=======================================
  Hits        32133    32133           
  Misses        602      602           
  Partials      201      201           
Flag Coverage Δ
CI-GHA 97.47% <ø> (ø)
OS-Linux 97.13% <ø> (ø)
OS-Windows 95.70% <ø> (-0.11%) ⬇️
OS-macOS 96.85% <ø> (-0.11%) ⬇️
Py-3.10.11 95.55% <ø> (ø)
Py-3.10.13 96.69% <ø> (ø)
Py-3.10.14 96.91% <ø> (ø)
Py-3.11.8 97.13% <ø> (+0.20%) ⬆️
Py-3.12.2 97.26% <ø> (+0.20%) ⬆️
Py-3.8.10 95.53% <ø> (ø)
Py-3.8.18 96.88% <ø> (ø)
Py-3.9.13 95.52% <ø> (ø)
Py-3.9.18 96.66% <ø> (ø)
Py-3.9.19 96.88% <ø> (ø)
Py-pypy7.3.15 96.45% <ø> (ø)
VM-macos 96.85% <ø> (-0.11%) ⬇️
VM-ubuntu 97.13% <ø> (ø)
VM-windows 95.70% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit f78ef6f into master Mar 28, 2024
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-4 branch March 28, 2024 22:29
@patchback
Copy link
Contributor

patchback bot commented Mar 28, 2024

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/f78ef6f8e9e3a9503f3a17357cb4aad63c0df43d/pr-8259

Backported as #8261

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 28, 2024
(cherry picked from commit f78ef6f)
@patchback
Copy link
Contributor

patchback bot commented Mar 28, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/f78ef6f8e9e3a9503f3a17357cb4aad63c0df43d/pr-8259

Backported as #8262

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 28, 2024
(cherry picked from commit f78ef6f)
Dreamsorcerer added a commit that referenced this pull request Mar 28, 2024
**This is a backport of PR #8259 as merged into master
(f78ef6f).**

Co-authored-by: Sam Bull <[email protected]>
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't realize the tests are passing already!

@Dreamsorcerer
Copy link
Member Author

Nice, I didn't realize the tests are passing already!

bdraco just fixed a race condition a few hours earlier which was the cause of the failures.

Dreamsorcerer added a commit that referenced this pull request Mar 30, 2024
**This is a backport of PR #8259 as merged into master
(f78ef6f).**

Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants