Skip to content

Conversation

Cycloctane
Copy link
Member

@Cycloctane Cycloctane commented Sep 30, 2025

What do these changes do?

Websocket frame compression tests in test_websocket_writer use hard-coded bytes to verify output. This pr replaces them with payload generated by current ZLibBackend to support various zlib implementation.

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

#11503

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder

@Cycloctane Cycloctane added the backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot label Sep 30, 2025
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.68%. Comparing base (9a2f146) to head (3073bf1).
⚠️ Report is 9 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11546   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files         127      127           
  Lines       43371    43378    +7     
  Branches     2325     2325           
=======================================
+ Hits        42800    42807    +7     
  Misses        416      416           
  Partials      155      155           
Flag Coverage Δ
CI-GHA 98.56% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.30% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.62% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.50% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.14% <100.00%> (+<0.01%) ⬆️
Py-3.10.18 97.64% <100.00%> (-0.01%) ⬇️
Py-3.11.13 97.84% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.34% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 97.44% <100.00%> (+<0.01%) ⬆️
Py-3.12.11 97.95% <100.00%> (+<0.01%) ⬆️
Py-3.13.7 98.20% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.03% <100.00%> (+<0.01%) ⬆️
Py-3.9.23 97.54% <100.00%> (+<0.01%) ⬆️
Py-pypy3.9.19-7.3.16 89.10% <58.33%> (-5.16%) ⬇️
VM-macos 97.50% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.30% <100.00%> (+<0.01%) ⬆️
VM-windows 96.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 30, 2025

CodSpeed Performance Report

Merging #11546 will not alter performance

Comparing Cycloctane:fix-ws_writer_compress_tests (3073bf1) with master (e752b3e)

Summary

✅ 59 untouched

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 30, 2025
@Dreamsorcerer Dreamsorcerer merged commit 92dee75 into aio-libs:master Oct 4, 2025
40 of 42 checks passed
Copy link
Contributor

patchback bot commented Oct 4, 2025

Backport to 3.13: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 92dee75 on top of patchback/backports/3.13/92dee75c51badcceab2b6dc85ed36e028c08cd46/pr-11546

Backporting merged PR #11546 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.13/92dee75c51badcceab2b6dc85ed36e028c08cd46/pr-11546 upstream/3.13
  4. Now, cherry-pick PR Refactor websocket frame compression tests in test_websocket_writer #11546 contents into that branch:
    $ git cherry-pick -x 92dee75c51badcceab2b6dc85ed36e028c08cd46
    If it'll yell at you with something like fatal: Commit 92dee75c51badcceab2b6dc85ed36e028c08cd46 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 92dee75c51badcceab2b6dc85ed36e028c08cd46
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Refactor websocket frame compression tests in test_websocket_writer #11546 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.13/92dee75c51badcceab2b6dc85ed36e028c08cd46/pr-11546
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Cycloctane added a commit to Cycloctane/aiohttp that referenced this pull request Oct 4, 2025
Dreamsorcerer pushed a commit that referenced this pull request Oct 4, 2025
…on tests in test_websocket_writer (#11556)

(cherry picked from commit 92dee75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants