-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Refactor websocket frame compression tests in test_websocket_writer #11546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor websocket frame compression tests in test_websocket_writer #11546
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11546 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 127 127
Lines 43371 43378 +7
Branches 2325 2325
=======================================
+ Hits 42800 42807 +7
Misses 416 416
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #11546 will not alter performanceComparing Summary
|
Backport to 3.13: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 92dee75 on top of patchback/backports/3.13/92dee75c51badcceab2b6dc85ed36e028c08cd46/pr-11546 Backporting merged PR #11546 into master
🤖 @patchback |
…io-libs#11546) (cherry picked from commit 92dee75)
What do these changes do?
Websocket frame compression tests in test_websocket_writer use hard-coded bytes to verify output. This pr replaces them with payload generated by current ZLibBackend to support various zlib implementation.
Are there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
#11503
Checklist
CONTRIBUTORS.txt
CHANGES/
folder