fix thread safety of http writer #11464
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11464 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 129 129
Lines 43418 43418
Branches 2325 2325
=======================================
+ Hits 42876 42879 +3
+ Misses 387 384 -3
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #11464 will not alter performanceComparing Summary
|
bdraco
added
backport-3.12
backport-3.13
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #11468 🤖 @patchback |
(cherry picked from commit 945837c)
Backport to 3.13: 💚 backport PR created✅ Backport PR branch: Backported as #11469 🤖 @patchback |
(cherry picked from commit 945837c)
…11469) **This is a backport of PR #11464 as merged into master (945837c).** Co-authored-by: Kumar Aditya <[email protected]>
…11468) **This is a backport of PR #11464 as merged into master (945837c).** Co-authored-by: Kumar Aditya <[email protected]>
3 participants
What do these changes do?
This makes the http writer cython extension thread safe. Previously it used a global static buffer which would be shared across threads, now the buffer is stack allocated which avoids this and makes it thread safe.
This also marks the cython extensions with
freethreading_compatiblemarker.Are there changes in behavior for the user?
No change.
Is it a substantial burden for the maintainers to support this?
No
Related issue number
#8796
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.