Skip to content

Add missing prepared method for WebSocketResponse to docs #10988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2025
Merged

Add missing prepared method for WebSocketResponse to docs #10988

merged 4 commits into from
May 23, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 23, 2025 •
edited
Loading

We now override this method so we should document it. I should have used :py:attr:~aiohttp.web.WebSocketResponse.prepared

@bdraco
Adjust changelog message for #6009
61d8cdd 
I forgot to add the reference
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.11 labels May 23, 2025
@codecov Codecov
Copy link

codecov bot commented May 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (2617ab2) to head (a9b612d).
⚠️ Report is 476 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10988      +/-   ##
==========================================
+ Coverage   97.89%   98.77%   +0.87%     
==========================================
  Files         127      129       +2     
  Lines       39557    39624      +67     
  Branches     2176     2187      +11     
==========================================
+ Hits        38726    39137     +411     
+ Misses        672      339     -333     
+ Partials      159      148      -11
Flag Coverage Δ
CI-GHA 98.65% <ø> (+0.85%) ⬆️
OS-Linux 98.36% <ø> (?)
OS-Windows 96.54% <ø> (+0.04%) ⬆️
OS-macOS 97.51% <ø> (+0.20%) ⬆️
Py-3.10.11 97.40% <ø> (?)
Py-3.10.17 97.94% <ø> (?)
Py-3.11.12 98.02% <ø> (?)
Py-3.11.9 97.49% <ø> (+1.27%) ⬆️
Py-3.12.10 98.42% <ø> (+1.12%) ⬆️
Py-3.13.3 98.42% <ø> (?)
Py-3.9.13 97.28% <ø> (+1.26%) ⬆️
Py-3.9.22 97.80% <ø> (?)
Py-pypy7.3.16 93.60% <ø> (?)
VM-macos 97.51% <ø> (+0.20%) ⬆️
VM-ubuntu 98.36% <ø> (?)
VM-windows 96.54% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 23, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10988 will not alter performance

Comparing changelog_message_tweak_6009 (a9b612d) with master (2617ab2)

Summary

✅ 59 untouched benchmarks

@bdraco bdraco removed the bot:chronographer:skip This PR does not need to include a change note label May 23, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 23, 2025
@bdraco bdraco changed the title Adjust changelog message for #6009 Add missing prepared method for WebSocketResponse to docs May 23, 2025
bdraco
bdraco commented May 23, 2025
View reviewed changes
@bdraco bdraco marked this pull request as ready for review May 23, 2025 20:31
@bdraco bdraco requested review from asvetlov and webknjaz as code owners May 23, 2025 20:31
@bdraco bdraco enabled auto-merge (squash) May 23, 2025 20:31
@bdraco bdraco mentioned this pull request May 23, 2025
Merged
@bdraco bdraco merged commit 54f1a84 into master May 23, 2025
39 checks passed
@bdraco bdraco deleted the changelog_message_tweak_6009 branch May 23, 2025 20:37
@patchback Patchback
Copy link
Contributor

patchback bot commented May 23, 2025 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/54f1a84f51f0aeceec04386f2eb237d430d9aa85/pr-10988

Backported as #10989

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 23, 2025
@bdraco @patchback
Add missing prepared method for WebSocketResponse to docs (#10988)
4e056ad 
(cherry picked from commit 54f1a84)
@patchback Patchback
Copy link
Contributor

patchback bot commented May 23, 2025 •
edited
Loading

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/54f1a84f51f0aeceec04386f2eb237d430d9aa85/pr-10988

Backported as #10990

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request May 23, 2025
Merged
patchback bot pushed a commit that referenced this pull request May 23, 2025
@bdraco @patchback
Add missing prepared method for WebSocketResponse to docs (#10988)
d10859d 
(cherry picked from commit 54f1a84)
@patchback patchback bot mentioned this pull request May 23, 2025
Merged
bdraco added a commit that referenced this pull request May 23, 2025
@patchback @bdraco
[PR #10988/54f1a84f backport][3.12] Add missing prepared method for W…
fa088d0 
…ebSocketResponse to docs (#10990)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request May 23, 2025
@patchback @bdraco
[PR #10988/54f1a84f backport][3.11] Add missing prepared method for W…
0cbcab6 
…ebSocketResponse to docs (#10989)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bdraco