-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[3.12] Fix AsyncResolver not using the loop argument #10951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.12 #10951 +/- ##
=======================================
Coverage 98.16% 98.16%
=======================================
Files 130 130
Lines 39675 39690 +15
Branches 2242 2242
=======================================
+ Hits 38948 38963 +15
Misses 555 555
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10951 will not alter performanceComparing Summary
|
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 12ff66d on top of patchback/backports/3.11/12ff66d5312bd9df894e506f8802b133d0293b91/pr-10951 Backporting merged PR #10951 into 3.12
🤖 @patchback |
This PR is to 3.12 since we have dropped the loop argument on master
The loop argument was being ignored in AsyncResolver in 3.12/3.11 where it should still be supported
fixes #10787