Skip to content

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 22, 2025

regressed in #10847 but never in a stable release so I linked the changelog message instead of adding a bugfix.

@bdraco bdraco requested a review from asvetlov as a code owner May 22, 2025 19:32
@bdraco bdraco requested a review from webknjaz as a code owner May 22, 2025 19:33
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 22, 2025
@bdraco bdraco added this to the 3.12 milestone May 22, 2025
@bdraco bdraco enabled auto-merge (squash) May 22, 2025 19:35
Copy link

codecov bot commented May 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (b1e9462) to head (3891247).
⚠️ Report is 492 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10946   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         129      129           
  Lines       39458    39478   +20     
  Branches     2185     2186    +1     
=======================================
+ Hits        38973    38993   +20     
  Misses        337      337           
  Partials      148      148           
Flag Coverage Δ
CI-GHA 98.65% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.36% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.53% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.50% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.40% <100.00%> (-0.01%) ⬇️
Py-3.10.17 97.93% <100.00%> (-0.01%) ⬇️
Py-3.11.12 98.01% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.48% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 98.41% <100.00%> (-0.01%) ⬇️
Py-3.13.3 98.41% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.28% <100.00%> (+<0.01%) ⬆️
Py-3.9.22 97.81% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 79.33% <100.00%> (-18.04%) ⬇️
VM-macos 97.50% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.36% <100.00%> (+<0.01%) ⬆️
VM-windows 96.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Performance Report

Merging #10946 will not alter performance

Comparing async_resolver_close_many (3891247) with master (b1e9462)

Summary

✅ 59 untouched benchmarks

@bdraco bdraco merged commit 3c88f81 into master May 22, 2025
39 of 41 checks passed
@bdraco bdraco deleted the async_resolver_close_many branch May 22, 2025 19:42
Copy link
Contributor

patchback bot commented May 22, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/3c88f811390cebf524281bebfdbd807a57ab855e/pr-10946

Backported as #10947

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 22, 2025
bdraco added a commit that referenced this pull request May 22, 2025
…be called multiple times (#10947)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant