-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[3.12] Update to Cython 3.1.1 #10877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.12 #10877 +/- ##
=======================================
Coverage ? 98.09%
=======================================
Files ? 126
Lines ? 38057
Branches ? 2148
=======================================
Hits ? 37333
Misses ? 553
Partials ? 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10877 will not alter performanceComparing Summary
|
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 6ea542e on top of patchback/backports/3.11/6ea542ef4b78174b2b9c39146fc6f72abeaba2ce/pr-10877 Backporting merged PR #10877 into 3.12
🤖 @patchback |
What do these changes do?
Overview
This commit fixes compilation issues with Cython 3.1.1 for the 3.12 branch.
Changes Made
1. Updated Cython Version
requirements/cython.txt
requirements/constraints.txt
2. Fixed Type Annotation
aiohttp/_websocket/reader_py.py
:exc: "BaseException"
toexc: BaseException
Purpose
This is a compatibility fix to ensure the project can compile successfully with the newer version of Cython 3.1.1.
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no
replaces and closes #10849