Skip to content

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented May 3, 2025

This is a backport of PR #10823 as merged into master (d17f2a4).

Remove constraint that prevented aiodns from being installed on Windows
As of aiodns 3.3.0 SelectorEventLoop is no longer required when using pycares 4.7.0 or later

Are there changes in behavior for the user?

aiodns is now available on windows

Is it a substantial burden for the maintainers to support this?

no

Related issue number

closes #8121

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

…10823)

Remove constraint that prevented aiodns from being installed on Windows
As of aiodns 3.3.0 SelectorEventLoop is no longer required when using
pycares 4.7.0 or later

(cherry picked from commit d17f2a4)
Copy link

codecov bot commented May 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (3.12@f3d2fbb). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10825   +/-   ##
=======================================
  Coverage        ?   98.11%           
=======================================
  Files           ?      126           
  Lines           ?    38022           
  Branches        ?     2146           
=======================================
  Hits            ?    37306           
  Misses          ?      545           
  Partials        ?      171           
Flag Coverage Δ
CI-GHA 98.00% <ø> (?)
OS-Linux 97.71% <ø> (?)
OS-Windows 95.13% <ø> (?)
OS-macOS 96.86% <ø> (?)
Py-3.10.11 96.74% <ø> (?)
Py-3.10.17 97.30% <ø> (?)
Py-3.11.12 97.40% <ø> (?)
Py-3.11.9 96.84% <ø> (?)
Py-3.12.10 97.79% <ø> (?)
Py-3.13.3 97.77% <ø> (?)
Py-3.9.13 96.63% <ø> (?)
Py-3.9.22 97.17% <ø> (?)
Py-pypy7.3.16 88.24% <ø> (?)
VM-macos 96.86% <ø> (?)
VM-ubuntu 97.71% <ø> (?)
VM-windows 95.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 3, 2025

CodSpeed Performance Report

Merging #10825 will not alter performance

Comparing patchback/backports/3.12/d17f2a4cfb4fedc8cc9bede160a41a46b7a9e45d/pr-10823 (dd9cd22) with 3.12 (60f15a4)

Summary

✅ 58 untouched benchmarks

@bdraco bdraco merged commit 1d6961a into 3.12 May 3, 2025
70 of 94 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/d17f2a4cfb4fedc8cc9bede160a41a46b7a9e45d/pr-10823 branch May 3, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant