Raise TypeError when setting StreamResponse.last_modified to an unsupported type
#10146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pported type Currently this would silently fail and discard the new value. fixes #10143
psf-chronographer
bot
added
the
bot:chronographer:provided
CodSpeed Performance ReportMerging #10146 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10146 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 122 122
Lines 36954 36960 +6
Branches 4411 4412 +1
=======================================
+ Hits 36494 36501 +7
Misses 313 313
+ Partials 147 146 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
added
backport:skip
|
Thought about it some more, and probably ok to backport to 3.12 but not 3.11 |
Dreamsorcerer
approved these changes
Dec 8, 2024
|
|
bdraco
changed the title
ValueError when setting StreamResponse.last_modified to an unsupported typeTypeError when setting StreamResponse.last_modified to an unsupported type
bdraco
commented
Dec 8, 2024
bdraco
commented
Dec 8, 2024
bdraco
commented
Dec 8, 2024
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10161 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
…nsupported type (#10146) <!-- Thank you for your contribution! --> ## What do these changes do? closes #10143 ## Are there changes in behavior for the user? Currently this would silently fail and discard the new value. <img width="685" alt="Screenshot 2024-12-08 at 12 32 49 PM" src="https://github.com/user-attachments/assets/b0cf00c3-cd2e-4be6-af94-d993491bd296"> (cherry picked from commit a818e51)
bdraco
pushed a commit
that referenced
this pull request
Dec 12, 2024
…treamResponse.last_modified` to an unsupported type (#10161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
closes #10143
Are there changes in behavior for the user?
Currently this would silently fail and discard the new value.