Skip to content

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Dec 2, 2024

This is a backport of PR #10074 as merged into master (f733258).

What do these changes do?

Support absolute url in request to override base url in session.

session = ClientSession(base_url="http://example.com/foo/")

await session.request("GET", "http://abc.com/bar/")

Are there changes in behavior for the user?

Yes

Is it a substantial burden for the maintainers to support this?

No

Related issue number

Fixes #10027

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
(cherry picked from commit f733258)
@bdraco bdraco enabled auto-merge (squash) December 2, 2024 14:32
@bdraco bdraco disabled auto-merge December 2, 2024 14:33
@bdraco bdraco enabled auto-merge (squash) December 2, 2024 14:33
Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #10094 will not alter performance

Comparing patchback/backports/3.12/f733258ed9e5e71b7b97511f5654efd6799cac46/pr-10074 (ffe7c27) with 3.12 (6865d6b)

Summary

✅ 44 untouched benchmarks

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (6865d6b) to head (ffe7c27).
Report is 193 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.12   #10094      +/-   ##
==========================================
- Coverage   98.06%   98.06%   -0.01%     
==========================================
  Files         122      122              
  Lines       37052    37051       -1     
  Branches     4453     4453              
==========================================
- Hits        36335    36334       -1     
  Misses        540      540              
  Partials      177      177              
Flag Coverage Δ
CI-GHA 97.95% <100.00%> (-0.01%) ⬇️
OS-Linux 97.66% <100.00%> (-0.01%) ⬇️
OS-Windows 94.57% <ø> (ø)
OS-macOS 96.77% <100.00%> (-0.01%) ⬇️
Py-3.10.11 96.63% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.22% <100.00%> (-0.01%) ⬇️
Py-3.11.10 97.23% <100.00%> (-0.01%) ⬇️
Py-3.11.9 96.70% <100.00%> (-0.02%) ⬇️
Py-3.12.7 97.72% <100.00%> (-0.01%) ⬇️
Py-3.13.0 97.71% <100.00%> (-0.01%) ⬇️
Py-3.9.13 96.56% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.14% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.70% <100.00%> (-0.01%) ⬇️
VM-macos 96.77% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.66% <100.00%> (-0.01%) ⬇️
VM-windows 94.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit d872e34 into 3.12 Dec 2, 2024
35 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/f733258ed9e5e71b7b97511f5654efd6799cac46/pr-10074 branch December 2, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants