Improvements to static routes

[playpauseandstop]

I got into two problems with static routes recently,

1. There are no default ability to enable HEAD requests to static routes
2. Sometimes we need to serve lone static files as routes instead of serving static files inside of static dir

---

Workaround to 1st problem,

app.router.add_static('/static/', static_dir, name='static')
route = web.StaticRoute(None, '/static/', static_dir)
route._method = 'HEAD'
app.router.register_route(route)

Not very elegant solution, IMO

---

Workaround to 2nd problem,

def view_factory(url, path):
    async def static_view(request):
        prefix = url.rsplit('/', 1)[0] or '/'
        route = web.StaticRoute(None, prefix, static_dir)

        request.match_info['filename'] = path
        return await route.handle(request)
    return static_view

view = static_view('/', 'pages/index.html')
app.router.add_route('GET', '/', view_factory('/', 'pages/index.html'))
app.router.add_route('GET', 
                     '/favicon.ico', 
                     view_factory('/favicon.ico', 'favicon/favicon.ico'))

---

In total, I propose imrpove static routes by,

• Adding ability to setup routing HEAD requests to the static files on adding static route
• Adding shortcut or refactor Static Route to be able serve separate files

[asvetlov]

Sounds good.
Are you volunteered for the task ?

[playpauseandstop]

@asvetlov

Ok, will try to make a PR today or next week

[redixin]

IMO router shouldn't have anything related to serving files. We can have some handler for this:

    from aiohttp import handlers
    app.router.add_route('GET', '/media/', handlers.static('/var/www/media/', indexes=True))

As for HEAD we can allow specifying multiple methods:

    app.router.add_route({'GET', 'HEAD'}, 'media', handlers.static('/var/www/media/'))

And ok. We can still have an alias for setting static route, which will just call add_route with proper handler:

    app.router.add_static('/static/', static_dir, name='static')

and inside add_static:

     def add_static(self, *args, **kw):
          self.add_route({'GET', 'HEAD'}, handlers.static(*args, **kw))

[asvetlov]

@redixin path param for .add_route should specify full url path, not prefix only. That makes path ugly for static file serving.

[rutsky]

@redixin, you mentined indexes=True --- any plans for implementing directory listings for static directories?
I think simple directory listings is a good feature.

[redixin]

@rutsky I want to finish logging first(#572). After that I can try to look deep into routes/static/indexes.

[playpauseandstop]

@redixin

Great suggestion on having handlers for serving static files. Totally agreed with it!

[binhnq94]

Plzz, illustrate where the docs for this solution. 💃

[eteamin]

@redixin Thank you

[asvetlov]

Thanks to @dkuznetsov and #901 now we have a FileSender class for sending local file via the wire.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.