Force aiohttp.web handlers to coroutines

[asvetlov]

Now handler may be a regular function.

I guess to stop support for this behavior and raise an exception in router.add_route() if non-coroutine has passed.

@fafhrd91 you have guessed this earlier, do you agree with proposed change now?

[fafhrd91]

i actually like that you can use normal function as handler.

@kxepal @popravich ?

[asvetlov]

I'll probably publish PR for middlewares at this weekend.
Middleware implementation may be easier with coroutines-only.

[fafhrd91]

how about wrapping non-coroutine handlers into coroutine inside add_route then?

[ludovic-gasc]

+1 for coroutines only.
In API-Hour, I'd authorised a mix of coroutines and simple functions.
Finally, after several real world projects with my colleagues, we replace more and more simple functions by coroutines.

[asvetlov]

I'm ok with automatic converting in router.add_route().

[popravich]

+1 for automatic converting.
In our tests we use mock-server which just returns prepared answers so its handlers are just functions.
This way it more readable and simple to understand.

[asvetlov]

Done

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.