-
-
Notifications
You must be signed in to change notification settings - Fork 200
Bump botocore
dependency specification
#1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
26aa942
to
86869b7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1348 +/- ##
==========================================
- Coverage 90.88% 90.63% -0.25%
==========================================
Files 67 67
Lines 6569 6597 +28
==========================================
+ Hits 5970 5979 +9
- Misses 599 618 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
86869b7
to
0ca6c4a
Compare
@thehesiod: Thanks for the review. Auto-merge is unavailable due to the low patch coverage. I checked the unit tests ported by @stj in #1323 and believe that even with those, patch coverage would be imperfect. This is probably due to a lack of test coverage in upstream. May I suggest we merge this PR now and cut a release? |
Thanks @jakob-keller! Am happy to close my PR and skip on all the tests that I pulled from upstream. |
I'm afraid, botocore 1.37.4 will be a challenge due to the introduction of client contexts. |
shouldn't be too bad, contextvars should "just work" in asyncio as in asyncio they're tied to the task...caveat though in that you need to make sure you create the context while in an async method. |
@thehesiod: Thanks, I'll cut a release, if you don't mind. |
Description of Change
This PR intends to improve general compatibility of
aiobotocore
within the Python ecosystem by bumping the dependency specification ofbotocore
, as well asboto3
andawscli
.Assumptions
Upstream contains changes that require adjustments to the aiobotocore codebase.
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions