Skip to content

Bump botocore dependency specification #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by bumping the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

Upstream contains changes that require adjustments to the aiobotocore codebase.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Apr 29, 2025
@jakob-keller jakob-keller marked this pull request as draft April 29, 2025 17:32
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

❌ Patch coverage is 34.48276% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.63%. Comparing base (d2d8f2b) to head (0ca6c4a).
⚠️ Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
aiobotocore/parsers.py 32.14% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1348      +/-   ##
==========================================
- Coverage   90.88%   90.63%   -0.25%     
==========================================
  Files          67       67              
  Lines        6569     6597      +28     
==========================================
+ Hits         5970     5979       +9     
- Misses        599      618      +19     
Flag Coverage Δ
unittests 90.63% <34.48%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakob-keller jakob-keller marked this pull request as ready for review April 29, 2025 19:53
@jakob-keller jakob-keller enabled auto-merge April 29, 2025 19:54
@jakob-keller
Copy link
Collaborator Author

@thehesiod: Thanks for the review.

Auto-merge is unavailable due to the low patch coverage. I checked the unit tests ported by @stj in #1323 and believe that even with those, patch coverage would be imperfect. This is probably due to a lack of test coverage in upstream.

May I suggest we merge this PR now and cut a release?

@stj
Copy link
Contributor

stj commented Apr 29, 2025

Thanks @jakob-keller! Am happy to close my PR and skip on all the tests that I pulled from upstream.
Once this is merged, I'll take a look at updating to 1.37.5 with the User agent 2.1 enhancement.
+1 on a release with the changes to support CBOR.

@jakob-keller
Copy link
Collaborator Author

Once this is merged, I'll take a look at updating to 1.37.5 with the User agent 2.1 enhancement.

I'm afraid, botocore 1.37.4 will be a challenge due to the introduction of client contexts.

stj added a commit to stj/aiobotocore that referenced this pull request Apr 29, 2025
@thehesiod
Copy link
Collaborator

Once this is merged, I'll take a look at updating to 1.37.5 with the User agent 2.1 enhancement.

I'm afraid, botocore 1.37.4 will be a challenge due to the introduction of client contexts.

shouldn't be too bad, contextvars should "just work" in asyncio as in asyncio they're tied to the task...caveat though in that you need to make sure you create the context while in an async method.

@thehesiod thehesiod disabled auto-merge May 1, 2025 13:52
@thehesiod thehesiod merged commit 54dba34 into aio-libs:master May 1, 2025
19 of 20 checks passed
@jakob-keller jakob-keller deleted the bump-botocore branch May 1, 2025 13:57
@jakob-keller
Copy link
Collaborator Author

@thehesiod: Thanks, I'll cut a release, if you don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants