-
-
Notifications
You must be signed in to change notification settings - Fork 200
Patch ResponseParser
#1312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch ResponseParser
#1312
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1312 +/- ##
==========================================
+ Coverage 90.58% 90.76% +0.18%
==========================================
Files 68 68
Lines 6564 6553 -11
==========================================
+ Hits 5946 5948 +2
+ Misses 618 605 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b65bbe9
to
eb18a6a
Compare
@thehesiod: I believe this will make the pending botocore bump easier and aligns our class hierarchy with upstream. PS: I stumbled upon #1316 while working on this, too. |
eb18a6a
to
416c09c
Compare
416c09c
to
cdeef68
Compare
@jakob-keller did something go wrong in the merge queue? Looks odd that it hasn't finished in 5 days. |
ya something is weird with the merge queue, I'm not 100% up to date on how that's supposed to work and I don't see anything about manually re-triggering jobs |
toggled merge to master, lets c |
yay |
Description of Change
Patch
parsers.ResponseParser
to avoid duplicate code.Assumptions
Replace this text with any assumptions made (if any)
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions