Skip to content

Patch ResponseParser #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Patch parsers.ResponseParser to avoid duplicate code.

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Mar 1, 2025
@jakob-keller jakob-keller enabled auto-merge March 1, 2025 21:17
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.76%. Comparing base (416ff47) to head (cdeef68).
Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1312      +/-   ##
==========================================
+ Coverage   90.58%   90.76%   +0.18%     
==========================================
  Files          68       68              
  Lines        6564     6553      -11     
==========================================
+ Hits         5946     5948       +2     
+ Misses        618      605      -13     
Flag Coverage Δ
unittests 90.76% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakob-keller jakob-keller requested a review from thehesiod March 1, 2025 21:27
@jakob-keller jakob-keller force-pushed the AioResponseParser branch 3 times, most recently from b65bbe9 to eb18a6a Compare March 8, 2025 09:31
@jakob-keller
Copy link
Collaborator Author

@thehesiod: I believe this will make the pending botocore bump easier and aligns our class hierarchy with upstream.

PS: I stumbled upon #1316 while working on this, too.

@jakob-keller jakob-keller mentioned this pull request Apr 9, 2025
13 tasks
@jakob-keller jakob-keller added this pull request to the merge queue Apr 9, 2025
@stj
Copy link
Contributor

stj commented Apr 14, 2025

@jakob-keller did something go wrong in the merge queue? Looks odd that it hasn't finished in 5 days.

@thehesiod
Copy link
Collaborator

ya something is weird with the merge queue, I'm not 100% up to date on how that's supposed to work and I don't see anything about manually re-triggering jobs

@thehesiod thehesiod removed this pull request from the merge queue due to a manual request Apr 15, 2025
@thehesiod thehesiod added this pull request to the merge queue Apr 15, 2025
@thehesiod
Copy link
Collaborator

toggled merge to master, lets c

Merged via the queue into aio-libs:master with commit 41ca592 Apr 15, 2025
18 checks passed
@thehesiod
Copy link
Collaborator

yay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants